You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by kemsakurai <gi...@git.apache.org> on 2017/01/22 06:45:38 UTC
[GitHub] wicket pull request #205: Add Option isQuietly to StatelessChecker
GitHub user kemsakurai opened a pull request:
https://github.com/apache/wicket/pull/205
Add Option isQuietly to StatelessChecker
I used StatelessChecker from wicket-devutils, It is verifying whether it is StatelessPage or not.
Currently, when it is not StatelessPage, we throw exceptions without fail,
I logged an error and thought there was a use case I would like to check later.
For this reason, I would like to propose adding one option so that it can handle this use case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemsakurai/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit 5ffca55c7ed6658649942ef06a1b2fbd9947e5d7
Author: kensakurai <sa...@gmail.com>
Date: 2017-01-22T06:03:33Z
Merge Upstream
commit e58f3e065090148b7cfb4dda8165f17ca0adde68
Author: kensakurai <sa...@gmail.com>
Date: 2017-01-22T06:12:40Z
Revert "Merge Upstream"
This reverts commit 5ffca55c7ed6658649942ef06a1b2fbd9947e5d7.
commit 676066a77f56e1e67e8538fab4977fc2920de8d3
Author: kensakurai <sa...@gmail.com>
Date: 2017-01-22T06:15:31Z
Merge remote-tracking branch 'upstream/master'
commit 8289e514576165554864d352267449e2b9cccf81
Author: kensakurai <sa...@gmail.com>
Date: 2017-01-22T06:21:06Z
Add Option isQuietly to StatelessChecker
* For the Statefull component, I added an option to switch whether to
throw an exception or log
* I added a test case to confirm the addition of options
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #205: Add Option isQuietly to StatelessChecker
Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/205
As I understood it, he's using a customized copy of StatelessChecker that logs instead of throwing an exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #205: Add Option isQuietly to StatelessChecker
Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/205
Thanks for your patch. What do you think about a hook method instead, that people can override to do whatever they like with a failing component?
/**
* The given component claims to be stateless but isn't.
*
* @param component component failing stateless check
* @param reason explaining reason
*/
protected void fail(Component component, String reason)
{
throw new IllegalArgumentException("'" + component + "' claims to be stateless but isn't. " + reason);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #205: Add Option isQuietly to StatelessChecker
Posted by kemsakurai <gi...@git.apache.org>.
Github user kemsakurai closed the pull request at:
https://github.com/apache/wicket/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #205: Add Option isQuietly to StatelessChecker
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/205
I don't understand the problem and the suggest solution.
What do you mean by `we throw exceptions without fail` ?
Could you please re-phrase the description of this pull request? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #205: Add Option isQuietly to StatelessChecker
Posted by kemsakurai <gi...@git.apache.org>.
Github user kemsakurai commented on the issue:
https://github.com/apache/wicket/pull/205
I'm sorry. I am not very good at English and I did not get it well.
The description of pull request has been fixed.
Since I think that the method of making a suggested hook method is a better way,
I will reimplement it. This pull request is closed.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---