[GitHub] [geode] onichols-pivotal commented on a change in pull request #5115: Feature/GEODE-7414_2_redo

[GitBox <gi...@apache.org>]

onichols-pivotal commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r434918469



##########
File path: geode-core/src/main/java/org/apache/geode/net/SSLParameterExtensionContextImpl.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.net;
+
+public class SSLParameterExtensionContextImpl implements SSLParameterExtensionContext {
+  private int distributedSystemId;
+
+  public SSLParameterExtensionContextImpl(int distributedSystemIdInput) {
+    distributedSystemId = distributedSystemIdInput;
+  }
+
+  @Override
+  public int getDistributedSystemId() {
+    return distributedSystemId;
+  }
+
+  public void setDistributedSystemId(int distributedSystemIdInput) {
+    distributedSystemId = distributedSystemIdInput;
+  }

Review comment:
       is it necessary for this to be a mutable class?  I don't see setDistributedSystemId called anywhere.  If the constructor and getter are sufficient, I would discourage a setter...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org