You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2004/07/05 15:58:02 UTC
Re: svn commit: r10143 - in
trunk/subversion: libsvn_subr tests/libsvn_subr
On Mon, 2004-07-05 at 11:47, Klaus Rennecke wrote:
> >This check should no longer be necessary with the new
> >svn_path_canonicalize.
> Well, only if all callers canonicalize before ending up here. I don't
> have enough overview to judge this so I kept the behaviour identical.
All Subversion path functions except for a few special cases are assumed
to accept canonicalized internal paths, if I understand right.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10143 - in trunk/subversion: libsvn_subr tests/libsvn_subr
Posted by Josh Pieper <jj...@pobox.com>.
Klaus Rennecke wrote:
> Greg Hudson wrote:
>
> >[...]
> >
> >All Subversion path functions except for a few special cases are assumed
> >to accept canonicalized internal paths, if I understand right.
> >
> >
>
> Well then it's probably best to remove that check lest it gives the
> impression to the contrary.
Thanks! I applied your patch in r10145 and added a docstring. In the
future, it is a good idea to include a HACKING formatted log message
with any patch you submit to the list.
-Josh
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10143 - in trunk/subversion: libsvn_subr tests/libsvn_subr
Posted by Klaus Rennecke <kl...@rennecke.de>.
Greg Hudson wrote:
> [...]
>
>All Subversion path functions except for a few special cases are assumed
>to accept canonicalized internal paths, if I understand right.
>
>
Well then it's probably best to remove that check lest it gives the
impression to the contrary.
/Klaus
Re: svn commit: r10143 - in trunk/subversion: libsvn_subr tests/libsvn_subr
Posted by Ben Reser <be...@reser.org>.
On Mon, Jul 05, 2004 at 11:58:02AM -0400, Greg Hudson wrote:
> On Mon, 2004-07-05 at 11:47, Klaus Rennecke wrote:
> > >This check should no longer be necessary with the new
> > >svn_path_canonicalize.
>
> > Well, only if all callers canonicalize before ending up here. I don't
> > have enough overview to judge this so I kept the behaviour identical.
>
> All Subversion path functions except for a few special cases are assumed
> to accept canonicalized internal paths, if I understand right.
Correct, from svn_path.h:
All paths passed to the svn_path_xxx functions, with the exceptions of
the svn_path_canonicalize and svn_path_internal_style functions, must
be in canonical form.
(comment formatting and doxygen markup removed)
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org