You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/28 12:14:43 UTC
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7048: Optimizing mkallsyms scripts with python
anchao commented on code in PR #7048:
URL: https://github.com/apache/incubator-nuttx/pull/7048#discussion_r982325711
##########
arch/xtensa/src/Makefile:
##########
@@ -134,7 +134,7 @@ board/libboard$(LIBEXT):
$(Q) $(MAKE) -C board libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
define LINK_ALLSYMS
- $(Q) $(TOPDIR)/tools/mkallsyms.sh $(NUTTX) $(CROSSDEV) > allsyms.tmp
+ $(Q)$(TOPDIR)/tools/mkallsyms.py $(NUTTX) allsyms.tmp
Review Comment:
keep the space
##########
arch/arm/src/Makefile:
##########
@@ -157,7 +157,7 @@ board$(DELIM)libboard$(LIBEXT):
$(Q) $(MAKE) -C board libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
define LINK_ALLSYMS
- $(Q) $(TOPDIR)/tools/mkallsyms.sh $(NUTTX) $(CROSSDEV) > allsyms.tmp
Review Comment:
$(CROSSDEV) is mandatory, otherwise nm will print some unnecessary information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org