[jira] [Commented] (VCL-747) editOrAddGroup can have $ownerid undefined for add mode

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188630#comment-14188630 ] 

ASF subversion and git services commented on VCL-747:
-----------------------------------------------------

Commit 1635216 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1635216 ]

VCL-747 - editOrAddGroup can have $ownerid undefined for add mode
VCL-696 - Improve resource group deletion options and information

groups.php:
-modified editOrAddGroup: if user has user groups available for owning resource groups, but all of those groups have a different affiliation from the user, use the full list of user groups for what can be selected as the owning user group; added check for user group being a special (system) group, and if so, do not allow the name of the group to be modified
-modified processGroupInput: do not perform checks of name of group if $editname == 0
-modified confirmEditOrAddGroup: display name same way as federated and courseroll groups if $editname == 0
-modified confirmDeleteGroup: do not allow special (system) user groups to be deleted

> editOrAddGroup can have $ownerid undefined for add mode
> -------------------------------------------------------
>
>                 Key: VCL-747
>                 URL: https://issues.apache.org/jira/browse/VCL-747
>             Project: VCL
>          Issue Type: Bug
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>             Fix For: 2.4
>
>
> There is a portion of code that checks to see if the owning user group is in the list to be displayed in the drop down box when in "edit" mode. The code is also being run for Add mode. If $ownerid is set to "", an error is thrown. Adding a simple check to see if $ownerid != "" fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)