[GitHub] [linkis] CharlieYan24 commented on a diff in pull request #4359: feat: HiveEngineConn supports concurrency.(#4175)

["CharlieYan24 (via GitHub)" <gi...@apache.org>]

CharlieYan24 commented on code in PR #4359:
URL: https://github.com/apache/linkis/pull/4359#discussion_r1135105803


##########
linkis-engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/creation/HiveEngineConnFactory.scala:
##########
@@ -64,17 +68,22 @@ class HiveEngineConnFactory extends ComputationSingleExecutorEngineConnFactory w
           hiveSession.baos
         )
       case _ =>
-        throw HiveSessionStartFailedException(
-          CREATE_HIVE_EXECUTOR_ERROR.getErrorCode,
-          CREATE_HIVE_EXECUTOR_ERROR.getErrorDesc
-        )
+        new HiveEngineConcurrentConnExecutor(id)
     }
   }
 
   override protected def createEngineConnSession(
       engineCreationContext: EngineCreationContext
   ): HiveSession = {
-    val options = engineCreationContext.getOptions
+    // if hive engine support concurrent, hive session should init later
+    if (HiveEngineConfiguration.HIVE_ENGINE_CONCURRENT_SUPPORT) {
+      return null

Review Comment:
   good idea !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org