[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1500: CASSANDRA-17423 Add Native Transport Rate Limiter Options to Example cassandra.yaml and Expose Metric for Dispatch Rate

[GitBox <gi...@apache.org>]

josh-mckenzie commented on a change in pull request #1500:
URL: https://github.com/apache/cassandra/pull/1500#discussion_r827254248



##########
File path: conf/cassandra.yaml
##########
@@ -800,6 +800,16 @@ native_transport_allow_older_protocols: true
 # Idle connection timeouts are disabled by default.
 # native_transport_idle_timeout: 60000ms
 
+# When enabled, limits the number of native transport requests dispatched for processing per second.
+# Behavior once the limit has been breached depends on the value of THROW_ON_OVERLOAD specified in
+# the STARTUP message sent by the client during connection establishment. (See section "4.1.1. STARTUP"
+# in "CQL BINARY PROTOCOL v5".) With the THROW_ON_OVERLOAD flag enabled, messages that breach the limit
+# are dropped, and an OverloadedException is thrown for the client to handle. When the flag is not
+# enabled, the server will stop consuming messages from the channel/socket, putting backpressure on
+# the client while already dispatched messages are processed.
+# native_transport_rate_limiting_enabled: false
+# native_transport_max_requests_per_second: 1000000

Review comment:
       Why this default value? Thinking of an operator that might see this, say "Oh, I like this feature", and enable it thinking it's going to help them when 1M seems... high. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org