You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by mbroadst <gi...@git.apache.org> on 2016/06/28 13:41:47 UTC
[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...
GitHub user mbroadst opened a pull request:
https://github.com/apache/qpid/pull/10
feat(disposition): respect messageAnnotation mods in modified state
The modified outcome supports an optional messageAnnotations parameter, allowing the user to modify these annotations for subsequent redelivery with updated valus. This patch implements this behavior in qpidd
/cc @grs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbroadst/qpid modified-outcome-message-properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit f17b72669b6b27271f97f7992bfa35ffdbd06062
Author: Matt Broadstone <mb...@gmail.com>
Date: 2016-06-28T13:39:14Z
feat(disposition): respect messageAnnotation mods in modified state
The modified outcome supports an optional messageAnnotations
parameter, allowing the user to modify these annotations for
subsequent redelivery with updated valus. This patch implements
this behavior in qpid.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...
Posted by mbroadst <gi...@git.apache.org>.
Github user mbroadst commented on a diff in the pull request:
https://github.com/apache/qpid/pull/10#discussion_r68772313
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size)
pn_link_send(link, data, size);
}
+void OutgoingFromQueue::maybeMergeMessageAnnotations(const Record &r)
--- End diff --
sure works for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid issue #10: feat(disposition): respect messageAnnotation mods in modifie...
Posted by mbroadst <gi...@git.apache.org>.
Github user mbroadst commented on the issue:
https://github.com/apache/qpid/pull/10
updated (in case you didn't get a notification)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...
Posted by grs <gi...@git.apache.org>.
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid/pull/10#discussion_r68769620
--- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
@@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size)
pn_link_send(link, data, size);
}
+void OutgoingFromQueue::maybeMergeMessageAnnotations(const Record &r)
--- End diff --
Minor, subjective point on the method name: 'maybe' sounds vague, perhaps mergeAnnotationsIfRequired? or checkAndMergeAnnotations?
Change looks good though, thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid issue #10: feat(disposition): respect messageAnnotation mods in modifie...
Posted by grs <gi...@git.apache.org>.
Github user grs commented on the issue:
https://github.com/apache/qpid/pull/10
Thanks again Matt!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org