You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/26 12:48:01 UTC
[GitHub] [shardingsphere-elasticjob-lite] TeslaCN opened a new pull request #843: Remove JDBC driver dependency for elastic-job-lite-console #841
TeslaCN opened a new pull request #843:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/843
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- Removed MySQL JDBC driver dependency which is incompatible with ASF.
- Added ext-lib and updated start script to setup ext-lib into classpath
- Added document for using custom JDBC driver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #843: Remove JDBC driver dependency for elastic-job-lite-console
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #843:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] TeslaCN commented on a change in pull request #843: Remove JDBC driver dependency for elastic-job-lite-console
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #843:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/843#discussion_r446169112
##########
File path: elastic-job-lite-console/src/main/resources/bin/start.bat
##########
@@ -14,6 +14,7 @@ set PORT=%1
set CFG_DIR=%~dp0%..
set CLASSPATH=%CFG_DIR%
set CLASSPATH=%~dp0..\lib\*;%CLASSPATH%
+set CLASSPATH=$~dp0..\ext-lib\*;%CLASSPATH%
Review comment:
Ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #843: Remove JDBC driver dependency for elastic-job-lite-console
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #843:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/843#discussion_r446167830
##########
File path: elastic-job-lite-console/src/main/resources/bin/start.bat
##########
@@ -14,6 +14,7 @@ set PORT=%1
set CFG_DIR=%~dp0%..
set CLASSPATH=%CFG_DIR%
set CLASSPATH=%~dp0..\lib\*;%CLASSPATH%
+set CLASSPATH=$~dp0..\ext-lib\*;%CLASSPATH%
Review comment:
How about merge `\lib\` and `\ext-lib\` in same line?
##########
File path: elastic-job-lite-console/src/main/resources/bin/start.sh
##########
@@ -29,6 +29,7 @@ cd `dirname $0`
cd ..
DEPLOY_DIR=`pwd`
LIB_DIR=${DEPLOY_DIR}/lib/*
+LIB_DIR=${LIB_DIR}:${DEPLOY_DIR}/ext-lib/*
Review comment:
How about merge \lib\ and \ext-lib\ in same line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org