You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/04 06:39:05 UTC

[GitHub] [apisix-website] xdshivani opened a new pull request #328: docs: fixed kubernetes service api broken link

xdshivani opened a new pull request #328:
URL: https://github.com/apache/apisix-website/pull/328


   Fixes: #326 
   
   Changes:
   fixed kubernetes service api broken link
   
   Thankyou @iamayushdas for making me understand architecture of apisix-website. 
   Here is my first PR 
   Have a look to this
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-833173442


   What about other links, like etcd/travelsky/aliyun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848943324


   > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help
   
   It would be a pleasure to help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848941148


   The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu merged pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #328:
URL: https://github.com/apache/apisix-website/pull/328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848419123


   @LiteSun @xdshivani some other links need to be fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848800362


   @xdshivani
   see here for some reference
    ![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services through SLB]
   
   hope it helps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-849274914


   > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help
   
   It is already fixed now, thats why you aren't able to find the link


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: 267f0a725adbff5a7435dcfd8c2aee883f11ca70
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134](https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-328--apisix.netlify.app](https://deploy-preview-328--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848943324


   > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help
   
   I would be a pleasure to help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] LiteSun commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848401645


   ping~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-832009183


   > > There are quite a lot of broken links found in #326, we'd better fix them all together in this PR
   > 
   > 
   > 
   > I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.
   
   Oh yes, zh folder doesn't exist now in docs. You can look for other links, if all links are working fine just ping me here. 
   Thank you for contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > ![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use this link instead: http://www.sinog2c.com/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-833172958


   > > I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.
   > 
   > The reason those links are broken is due to, apisix-ingress-controller does not contain Chinese doc, but on Chinese website, the edit link is pointing to `zh` link. So the logic of multi-language doc edit links need to fix. But we could leave it to another PR.
   
   yes ofcourse, will look into it in another PR
   Thanks for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > ![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services through SLB]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-849274914


   > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help
   
   It is already fixed now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-833172368


   > I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.
   
   The reason those links are broken is due to, apisix-ingress-controller does not contain Chinese doc, but on Chinese website, the edit link is pointing to `zh` link. So the logic of multi-language doc edit links need to fix. But we could leave it to another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas removed a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848779841






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603


   Deploy preview for *apisix* processing.
   
   Building with commit b70a6a33beacc4747b94ac25ed8a5801e1da688c
   
   https://app.netlify.com/sites/apisix/deploys/6090ec022642840007d3b102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-833195913


   @xdshivani kindly have a look on other broken links residing there too like etcd/travelsky/aliyun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] xdshivani commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
xdshivani commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848591280


   1. I am new to open source and I don't know why I am receiving these errors.
   2. I tried to find the broken links in local repo but, could not find it.
   3. The only faulty link I got was of kubernetes link and I fixed it in this PR @Yiyiyimu  @iamayushdas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > ![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services through SLB]
   
   hope it helps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: 267f0a725adbff5a7435dcfd8c2aee883f11ca70
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134](https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848779841


   @xdshivani 
   see here for some reference
   ![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org