You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/04/02 09:38:30 UTC
[camel] branch main updated: replaced iterated addition to collection with bulk operation (#9755)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 446610367e5 replaced iterated addition to collection with bulk operation (#9755)
446610367e5 is described below
commit 446610367e556c18ba4c3e1b3110b8a200496512
Author: dk2k <dk...@users.noreply.github.com>
AuthorDate: Sun Apr 2 12:38:23 2023 +0300
replaced iterated addition to collection with bulk operation (#9755)
Co-authored-by: dk2k <dk...@ya.ru>
---
.../java/org/apache/camel/component/olingo2/api/impl/UriType.java | 5 ++---
.../apache/camel/component/quartz/QuartzManuallyTriggerJobTest.java | 4 +---
core/camel-util/src/main/java/org/apache/camel/util/HostUtils.java | 4 +---
.../org/apache/camel/maven/dsl/yaml/GenerateYamlSupportMojo.java | 4 +---
.../java/org/apache/camel/maven/dsl/yaml/support/ToolingSupport.java | 5 ++---
5 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/components/camel-olingo2/camel-olingo2-api/src/main/java/org/apache/camel/component/olingo2/api/impl/UriType.java b/components/camel-olingo2/camel-olingo2-api/src/main/java/org/apache/camel/component/olingo2/api/impl/UriType.java
index acf358e014b..8f2bb8dd66d 100644
--- a/components/camel-olingo2/camel-olingo2-api/src/main/java/org/apache/camel/component/olingo2/api/impl/UriType.java
+++ b/components/camel-olingo2/camel-olingo2-api/src/main/java/org/apache/camel/component/olingo2/api/impl/UriType.java
@@ -17,6 +17,7 @@
package org.apache.camel.component.olingo2.api.impl;
import java.util.ArrayList;
+import java.util.Arrays;
/**
* Copied from Olingo2 core package.
@@ -120,9 +121,7 @@ public enum UriType {
private final ArrayList<SystemQueryOption> whiteList = new ArrayList<>();
UriType(final SystemQueryOption... compatibleQueryOptions) {
- for (SystemQueryOption queryOption : compatibleQueryOptions) {
- whiteList.add(queryOption);
- }
+ whiteList.addAll(Arrays.asList(compatibleQueryOptions));
}
public boolean isCompatible(final SystemQueryOption queryOption) {
diff --git a/components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzManuallyTriggerJobTest.java b/components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzManuallyTriggerJobTest.java
index 3688811a585..539eb543b2a 100644
--- a/components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzManuallyTriggerJobTest.java
+++ b/components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzManuallyTriggerJobTest.java
@@ -42,9 +42,7 @@ public class QuartzManuallyTriggerJobTest extends BaseQuartzTest {
// collect all jobKeys of this route (ideally only one).
ArrayList<JobKey> jobKeys = new ArrayList<>();
for (String group : scheduler.getJobGroupNames()) {
- for (JobKey jobKey : scheduler.getJobKeys(GroupMatcher.jobGroupEquals(group))) {
- jobKeys.add(jobKey);
- }
+ jobKeys.addAll(scheduler.getJobKeys(GroupMatcher.jobGroupEquals(group)));
}
JobDataMap jobDataMap = scheduler.getJobDetail(jobKeys.get(0)).getJobDataMap();
diff --git a/core/camel-util/src/main/java/org/apache/camel/util/HostUtils.java b/core/camel-util/src/main/java/org/apache/camel/util/HostUtils.java
index 8b40f973851..c6716afa075 100644
--- a/core/camel-util/src/main/java/org/apache/camel/util/HostUtils.java
+++ b/core/camel-util/src/main/java/org/apache/camel/util/HostUtils.java
@@ -76,9 +76,7 @@ public final class HostUtils {
for (Map.Entry<String, Set<InetAddress>> entry : interfaceAddressMap.entrySet()) {
Set<InetAddress> addresses = entry.getValue();
if (!addresses.isEmpty()) {
- for (InetAddress address : addresses) {
- allAddresses.add(address);
- }
+ allAddresses.addAll(addresses);
}
}
return allAddresses;
diff --git a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlSupportMojo.java b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlSupportMojo.java
index 5cab062c0b8..8236562a979 100644
--- a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlSupportMojo.java
+++ b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlSupportMojo.java
@@ -259,9 +259,7 @@ public abstract class GenerateYamlSupportMojo extends AbstractMojo {
}
String[] elements = item.split(",");
- for (String element : elements) {
- answer.add(element);
- }
+ answer.addAll(Arrays.asList(elements));
}
return answer.stream();
diff --git a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/support/ToolingSupport.java b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/support/ToolingSupport.java
index 818390857e3..64a41855676 100644
--- a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/support/ToolingSupport.java
+++ b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/support/ToolingSupport.java
@@ -18,6 +18,7 @@ package org.apache.camel.maven.dsl.yaml.support;
import java.io.File;
import java.io.IOException;
+import java.util.Arrays;
import java.util.Set;
import java.util.TreeSet;
import java.util.stream.Stream;
@@ -41,9 +42,7 @@ public final class ToolingSupport {
}
String[] elements = item.split(",");
- for (String element : elements) {
- answer.add(element);
- }
+ answer.addAll(Arrays.asList(elements));
}
return answer.stream();