[GitHub] [apisix] bzp2010 commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

[GitBox <gi...@apache.org>]

bzp2010 commented on code in PR #6908:
URL: https://github.com/apache/apisix/pull/6908#discussion_r857216426


##########
t/admin/upstream-array-nodes.t:
##########
@@ -450,3 +450,38 @@ GET /t
 {"error_msg":"invalid configuration: property \"nodes\" validation failed: object matches none of the required"}
 --- no_error_log
 [error]
+
+
+
+=== TEST 14: nodes host include ipv6 addr
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/routes/1',
+                 ngx.HTTP_PUT,
+                 [[{
+                    "upstream": {
+                        "nodes": [
+                            {
+                                "host":"[::1]",

Review Comment:
   Is it valid only when using object's node? What happens if I use an array pattern like `[::1]:8080`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org