You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2021/01/18 07:04:00 UTC

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

    [ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267046#comment-17267046 ] 

Viraj Jasani commented on PHOENIX-5296:
---------------------------------------

Had an offline syncup with [~sandeep.pal] reg this. Since default HBase profiles available in master and 4.x are 2.4.0 and 1.6.0, now we can check for refCount leaks in relevant tests (good to get it in before upcoming releases).

> Ensure store file reader refcount is zero at end of relevant unit tests
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-5296
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5296
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Andrew Kyle Purtell
>            Assignee: Sandeep Pal
>            Priority: Major
>              Labels: phoenix-hardening
>             Fix For: 5.1.1, 4.16.1, 4.17.0
>
>
> Unit and integration tests for functional areas where the implementation wraps scanners and uses a delegate pattern should check at the end of the test that no scanners were leaked (check that all scanners including the inner scanners were properly closed) by testing that the store reader reference count is zero on all stores. 
> HBASE-22459 will offer a new metric and API which exposes this information. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)