You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/16 14:59:25 UTC
[GitHub] [skywalking-data-collect-protocol] zifeihan opened a new pull request #44: Update CDS(ConfigurationDiscoveryService) proto
zifeihan opened a new pull request #44:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/44
Update CDS(ConfigurationDiscoveryService) proto, avoid compilation failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #44: Update CDS(ConfigurationDiscoveryService) proto
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #44:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #44: Update CDS(ConfigurationDiscoveryService) proto
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #44:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/44#discussion_r558919408
##########
File path: language-agent/ConfigurationDiscoveryService.proto
##########
@@ -18,6 +18,8 @@
syntax = "proto3";
+package skywalking.v3;
+
option java_multiple_files = true;
option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3";
option csharp_namespace = "SkyWalking.NetworkProtocol";
Review comment:
option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #44: Update CDS(ConfigurationDiscoveryService) proto
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #44:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/44#discussion_r558919252
##########
File path: language-agent/ConfigurationDiscoveryService.proto
##########
@@ -18,6 +18,8 @@
syntax = "proto3";
+package skywalking.v3;
+
option java_multiple_files = true;
option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3";
option csharp_namespace = "SkyWalking.NetworkProtocol";
Review comment:
You miss `v3` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org