[GitHub] [druid] clintropolis commented on a change in pull request #9161: first/last aggregators and nulls

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9161: first/last aggregators and nulls
URL: https://github.com/apache/druid/pull/9161#discussion_r368788599
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregationTest.java
 ##########
 @@ -30,14 +30,16 @@
 import org.apache.druid.query.aggregation.TestObjectColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.column.ColumnHolder;
+import org.apache.druid.testing.InitializedNullHandlingTest;
 import org.easymock.EasyMock;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
 import java.nio.ByteBuffer;
+import java.util.Comparator;
 
-public class DoubleFirstAggregationTest
+public class DoubleFirstAggregationTest extends InitializedNullHandlingTest
 
 Review comment:
   travis runs tests in both modes, this is to let tests run in intellij which doesn't get initialized correctly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org