You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "He Yongqiang (JIRA)" <ji...@apache.org> on 2010/01/25 09:17:34 UTC

[jira] Created: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Disable streaming last table if there is a skew key in previous tables.
-----------------------------------------------------------------------

                 Key: HIVE-1094
                 URL: https://issues.apache.org/jira/browse/HIVE-1094
             Project: Hadoop Hive
          Issue Type: Bug
            Reporter: He Yongqiang


In JoinOperator's processOp()

{code} 
if(alias == numAliases -1){
if (sz == joinEmitInterval) {
{code} 

should be changed to
{code} 
if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
{code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804637#action_12804637 ] 

Namit Jain commented on HIVE-1094:
----------------------------------

I am not sure this is a good idea - for the last table, unless you stop streaming, you never know the size

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain resolved HIVE-1094.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6.0
     Hadoop Flags: [Reviewed]

committed. Thanks Yongqiang

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>             Fix For: 0.6.0
>
>         Attachments: hive.1094.patch
>
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804851#action_12804851 ] 

Namit Jain commented on HIVE-1094:
----------------------------------

+1

looks good - will commit if tests pass

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>         Attachments: hive.1094.patch
>
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1094:
---------------------------------

    Component/s: Query Processor

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>             Fix For: 0.6.0
>
>         Attachments: hive.1094.patch
>
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain reassigned HIVE-1094:
--------------------------------

    Assignee: He Yongqiang

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>             Fix For: 0.6.0
>
>         Attachments: hive.1094.patch
>
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1094) Disable streaming last table if there is a skew key in previous tables.

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1094:
-------------------------------

    Attachment: hive.1094.patch

hive.1094.patch contains a fix for both hive-1094 and hive-1090

> Disable streaming last table if there is a skew key in previous tables.
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1094
>                 URL: https://issues.apache.org/jira/browse/HIVE-1094
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>         Attachments: hive.1094.patch
>
>
> In JoinOperator's processOp()
> {code} 
> if(alias == numAliases -1){
> if (sz == joinEmitInterval) {
> {code} 
> should be changed to
> {code} 
> if(alias == numAliases - 1 && !(handleSkewJoin && skewJoinKeyContext.currBigKeyTag >= 0)
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.