You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2013/03/04 18:51:13 UTC

Master branch build is broken again

Hi there,

I could not compile master after pulling latest code today,  build failed with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-engine-orchestration: Compilation failure
[ERROR] /Users/minc/dev/cloud-asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/db/VMEntityVO.java:[52,7] org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not abstract and does not override abstract method getNewSvcOfferingId() in com.cloud.vm.VirtualMachine
[ERROR] -> [Help 1]

I checked the commit history, it seems related to commit e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can somebody quickly fix this? This is blocking me from verifying CLOUDSTACK-1491 and merge my feature branch vim51_win8.

       Thanks
-min

Re: Master branch build is broken again

Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 06, 2013 at 11:19:50AM +0530, Nitin Mehta wrote:
> Chip - This is relatively small feature and more or less isolated with
> other functionalities.
> IMHO I don¹t think it needs a different feature branch. I will definitely
> add unit tests for this though.

I disagree.  As Alex noted, you changed 18 files and the build obviously
broke because of it.  I'd assess this change as being one that "doing
the right thing" would be to have had a branch from which to propose a merge.
It's a gray area, but leaning towards more a conservative approach to
master branch stability will serve us well as a community.

> 
> Thanks,
> -Nitin
> 
> On 05/03/13 12:02 AM, "Chip Childers" <ch...@sungard.com> wrote:
> 
> >On Mon, Mar 04, 2013 at 10:00:24AM -0800, Alex Huang wrote:
> >> -1 on this checkin
> >> 
> >> And this is not a small change.  18 files.  Some large completely new
> >>methods checked in.  Changes to the virtual machine state machine.  No
> >>unit testing.   
> >> 
> >> I would reject this fix on these problems alone.
> >
> >Nitin,
> >
> >Shouldn't a change this big be in a feature branch, with a MERGE request
> >to bring it into master?
> >
> >> 
> >> --Alex
> >> 
> >> > -----Original Message-----
> >> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> >> > Sent: Monday, March 4, 2013 9:56 AM
> >> > To: cloudstack-dev@incubator.apache.org
> >> > Cc: Nitin Mehta; Abhinandan Prateek
> >> > Subject: RE: Master branch build is broken again
> >> > 
> >> > Min,
> >> > 
> >> > You should just revert the commit.
> >> > 
> >> > --Alex
> >> > 
> >> > > -----Original Message-----
> >> > > From: Min Chen [mailto:min.chen@citrix.com]
> >> > > Sent: Monday, March 4, 2013 9:51 AM
> >> > > To: cloudstack-dev@incubator.apache.org
> >> > > Cc: Nitin Mehta
> >> > > Subject: Master branch build is broken again
> >> > > Importance: High
> >> > >
> >> > > Hi there,
> >> > >
> >> > > I could not compile master after pulling latest code today,  build
> >> > > failed with the following error:
> >> > >
> >> > > [ERROR] Failed to execute goal
> >> > > org.apache.maven.plugins:maven-compiler-
> >> > > plugin:2.5.1:compile (default-compile) on project cloud-engine-
> >> > orchestration:
> >> > > Compilation failure [ERROR] /Users/minc/dev/cloud-
> >> > > 
> >>asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> >> > > /a
> >> > > pi/db/VMEntityVO.java:[52,7]
> >> > > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
> >> > > abstract and does not override abstract method getNewSvcOfferingId()
> >> > > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
> >> > >
> >> > > I checked the commit history, it seems related to commit
> >> > > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> >> > > somebody quickly fix this? This is blocking me from verifying
> >> > > CLOUDSTACK-
> >> > > 1491 and merge my feature branch vim51_win8.
> >> > >
> >> > >        Thanks
> >> > > -min
> >> > >
> >> 
> >> 
> 
>

Re: Master branch build is broken again

Posted by Nitin Mehta <Ni...@citrix.com>.
Chip - This is relatively small feature and more or less isolated with
other functionalities.
IMHO I don¹t think it needs a different feature branch. I will definitely
add unit tests for this though.

Thanks,
-Nitin

On 05/03/13 12:02 AM, "Chip Childers" <ch...@sungard.com> wrote:

>On Mon, Mar 04, 2013 at 10:00:24AM -0800, Alex Huang wrote:
>> -1 on this checkin
>> 
>> And this is not a small change.  18 files.  Some large completely new
>>methods checked in.  Changes to the virtual machine state machine.  No
>>unit testing.   
>> 
>> I would reject this fix on these problems alone.
>
>Nitin,
>
>Shouldn't a change this big be in a feature branch, with a MERGE request
>to bring it into master?
>
>> 
>> --Alex
>> 
>> > -----Original Message-----
>> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
>> > Sent: Monday, March 4, 2013 9:56 AM
>> > To: cloudstack-dev@incubator.apache.org
>> > Cc: Nitin Mehta; Abhinandan Prateek
>> > Subject: RE: Master branch build is broken again
>> > 
>> > Min,
>> > 
>> > You should just revert the commit.
>> > 
>> > --Alex
>> > 
>> > > -----Original Message-----
>> > > From: Min Chen [mailto:min.chen@citrix.com]
>> > > Sent: Monday, March 4, 2013 9:51 AM
>> > > To: cloudstack-dev@incubator.apache.org
>> > > Cc: Nitin Mehta
>> > > Subject: Master branch build is broken again
>> > > Importance: High
>> > >
>> > > Hi there,
>> > >
>> > > I could not compile master after pulling latest code today,  build
>> > > failed with the following error:
>> > >
>> > > [ERROR] Failed to execute goal
>> > > org.apache.maven.plugins:maven-compiler-
>> > > plugin:2.5.1:compile (default-compile) on project cloud-engine-
>> > orchestration:
>> > > Compilation failure [ERROR] /Users/minc/dev/cloud-
>> > > 
>>asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
>> > > /a
>> > > pi/db/VMEntityVO.java:[52,7]
>> > > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
>> > > abstract and does not override abstract method getNewSvcOfferingId()
>> > > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>> > >
>> > > I checked the commit history, it seems related to commit
>> > > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
>> > > somebody quickly fix this? This is blocking me from verifying
>> > > CLOUDSTACK-
>> > > 1491 and merge my feature branch vim51_win8.
>> > >
>> > >        Thanks
>> > > -min
>> > >
>> 
>>

Re: Master branch build is broken again

Posted by Chip Childers <ch...@sungard.com>.
On Mon, Mar 04, 2013 at 10:00:24AM -0800, Alex Huang wrote:
> -1 on this checkin
> 
> And this is not a small change.  18 files.  Some large completely new methods checked in.  Changes to the virtual machine state machine.  No unit testing.   
> 
> I would reject this fix on these problems alone.

Nitin,

Shouldn't a change this big be in a feature branch, with a MERGE request
to bring it into master?

> 
> --Alex
> 
> > -----Original Message-----
> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> > Sent: Monday, March 4, 2013 9:56 AM
> > To: cloudstack-dev@incubator.apache.org
> > Cc: Nitin Mehta; Abhinandan Prateek
> > Subject: RE: Master branch build is broken again
> > 
> > Min,
> > 
> > You should just revert the commit.
> > 
> > --Alex
> > 
> > > -----Original Message-----
> > > From: Min Chen [mailto:min.chen@citrix.com]
> > > Sent: Monday, March 4, 2013 9:51 AM
> > > To: cloudstack-dev@incubator.apache.org
> > > Cc: Nitin Mehta
> > > Subject: Master branch build is broken again
> > > Importance: High
> > >
> > > Hi there,
> > >
> > > I could not compile master after pulling latest code today,  build
> > > failed with the following error:
> > >
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-compiler-
> > > plugin:2.5.1:compile (default-compile) on project cloud-engine-
> > orchestration:
> > > Compilation failure [ERROR] /Users/minc/dev/cloud-
> > > asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> > > /a
> > > pi/db/VMEntityVO.java:[52,7]
> > > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
> > > abstract and does not override abstract method getNewSvcOfferingId()
> > > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
> > >
> > > I checked the commit history, it seems related to commit
> > > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> > > somebody quickly fix this? This is blocking me from verifying
> > > CLOUDSTACK-
> > > 1491 and merge my feature branch vim51_win8.
> > >
> > >        Thanks
> > > -min
> > >
> 
>

Re: Master branch build is broken again

Posted by Chip Childers <ch...@sungard.com>.
On Tue, Mar 05, 2013 at 10:10:45PM +0530, Prasanna Santhanam wrote:
> On Tue, Mar 05, 2013 at 11:15:18AM -0500, Min Chen wrote:
> > Thanks Prasanna. I did mvn build before merging to master locally,
> > not sure what happened here. Will check my local files again when I
> > am back to my computer.
> 
> Let's not just do a build. Let's also try to deploy the server. In this
> case the build was fine but the server fails to startup.

+1M

> 
> I'm trying to setup a jenkins job that will work the simulator to bring
> up a zone on a running server. But I ran into some circular
> dependencies on the simulator project. May be a mvn epiphany will come
> to me tonight and it'll be up tomorrow.
> 
> -- 
> Prasanna.,
>

Re: Master branch build is broken again

Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Mar 05, 2013 at 11:15:18AM -0500, Min Chen wrote:
> Thanks Prasanna. I did mvn build before merging to master locally,
> not sure what happened here. Will check my local files again when I
> am back to my computer.

Let's not just do a build. Let's also try to deploy the server. In this
case the build was fine but the server fails to startup.

I'm trying to setup a jenkins job that will work the simulator to bring
up a zone on a running server. But I ran into some circular
dependencies on the simulator project. May be a mvn epiphany will come
to me tonight and it'll be up tomorrow.

-- 
Prasanna.,

Re: Master branch build is broken again

Posted by Min Chen <mi...@citrix.com>.
Thanks Prasanna. I did mvn build before merging to master locally, not sure what happened here. Will check my local files again when I am back to my computer.

-min

Sent from my iPhone

On Mar 5, 2013, at 12:26 AM, "Prasanna Santhanam" <ts...@apache.org> wrote:

> Fixed now with b683c34d3f5fa47eecddd6bf6e90559ac04af9ba
> 
> Thanks to joe and dcahill.
> 
> On Tue, Mar 05, 2013 at 01:48:12PM +0530, Mills, Joseph wrote:
>> Hi Min,
>> 
>> Looks like something possibly got lost in the merge? In a git pull from a
>> couple of hours ago I am seeing the following error on starting the
>> management server. Note the spelling of "Hypervisor":
>> 
>> java.lang.ClassNotFoundException:
>> com.cloud.template.HyervisorTemplateAdapter
>> 
>> The issue is the misspelling in client/tomcatconf/componentContext.xml.in.
>> 
>> thanks,
>> Joe
>> 
>> On Tue, Mar 5, 2013 at 3:40 PM, Prasanna Santhanam <ts...@apache.org> wrote:
>> 
>>> On Tue, Mar 05, 2013 at 11:37:04AM +0530, Pradeep Soundararajan wrote:
>>>> It is broken. We are getting this error only in master branch.
>>>> 
>>>> Failed to execute goal on project cloud-vmware-base: Could not
>>>> resolve dependencies for project
>>>> org.apache.cloudstack:cloud-vmware-base:jar:4.2.0-SNAPSHOT: Failure
>>>> to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in
>>>> http://repo.maven.apache.org/maven2 was cached in the local
>>>> repository, resolution will not be reattempted until the update
>>>> interval of central has elapsed or updates are forced -> [Help 1]
>>>> 
>>> Did you check happen to miss Min's email from yesterday? If you are
>>> building nonoss you'll need the new vmware SDK for 5.1. Try
>>> downloading the new SDK (~50MB) and building with the new jar.
>>> 
>>> --
>>> Prasanna.,
>>> 
> 
> -- 
> Prasanna.,

Re: Master branch build is broken again

Posted by Prasanna Santhanam <ts...@apache.org>.
Fixed now with b683c34d3f5fa47eecddd6bf6e90559ac04af9ba

Thanks to joe and dcahill.

On Tue, Mar 05, 2013 at 01:48:12PM +0530, Mills, Joseph wrote:
> Hi Min,
> 
> Looks like something possibly got lost in the merge? In a git pull from a
> couple of hours ago I am seeing the following error on starting the
> management server. Note the spelling of "Hypervisor":
> 
> java.lang.ClassNotFoundException:
> com.cloud.template.HyervisorTemplateAdapter
> 
> The issue is the misspelling in client/tomcatconf/componentContext.xml.in.
> 
> thanks,
> Joe
> 
> On Tue, Mar 5, 2013 at 3:40 PM, Prasanna Santhanam <ts...@apache.org> wrote:
> 
> > On Tue, Mar 05, 2013 at 11:37:04AM +0530, Pradeep Soundararajan wrote:
> > > It is broken. We are getting this error only in master branch.
> > >
> > > Failed to execute goal on project cloud-vmware-base: Could not
> > > resolve dependencies for project
> > > org.apache.cloudstack:cloud-vmware-base:jar:4.2.0-SNAPSHOT: Failure
> > > to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in
> > > http://repo.maven.apache.org/maven2 was cached in the local
> > > repository, resolution will not be reattempted until the update
> > > interval of central has elapsed or updates are forced -> [Help 1]
> > >
> > Did you check happen to miss Min's email from yesterday? If you are
> > building nonoss you'll need the new vmware SDK for 5.1. Try
> > downloading the new SDK (~50MB) and building with the new jar.
> >
> > --
> > Prasanna.,
> >

-- 
Prasanna.,

Re: Master branch build is broken again

Posted by "Mills, Joseph" <jo...@midokura.jp>.
Hi Min,

Looks like something possibly got lost in the merge? In a git pull from a
couple of hours ago I am seeing the following error on starting the
management server. Note the spelling of "Hypervisor":

java.lang.ClassNotFoundException:
com.cloud.template.HyervisorTemplateAdapter

The issue is the misspelling in client/tomcatconf/componentContext.xml.in.

thanks,
Joe

On Tue, Mar 5, 2013 at 3:40 PM, Prasanna Santhanam <ts...@apache.org> wrote:

> On Tue, Mar 05, 2013 at 11:37:04AM +0530, Pradeep Soundararajan wrote:
> > It is broken. We are getting this error only in master branch.
> >
> > Failed to execute goal on project cloud-vmware-base: Could not
> > resolve dependencies for project
> > org.apache.cloudstack:cloud-vmware-base:jar:4.2.0-SNAPSHOT: Failure
> > to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in
> > http://repo.maven.apache.org/maven2 was cached in the local
> > repository, resolution will not be reattempted until the update
> > interval of central has elapsed or updates are forced -> [Help 1]
> >
> Did you check happen to miss Min's email from yesterday? If you are
> building nonoss you'll need the new vmware SDK for 5.1. Try
> downloading the new SDK (~50MB) and building with the new jar.
>
> --
> Prasanna.,
>

Re: Master branch build is broken again

Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Mar 05, 2013 at 11:37:04AM +0530, Pradeep Soundararajan wrote:
> It is broken. We are getting this error only in master branch.
> 
> Failed to execute goal on project cloud-vmware-base: Could not
> resolve dependencies for project
> org.apache.cloudstack:cloud-vmware-base:jar:4.2.0-SNAPSHOT: Failure
> to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in
> http://repo.maven.apache.org/maven2 was cached in the local
> repository, resolution will not be reattempted until the update
> interval of central has elapsed or updates are forced -> [Help 1]
> 
Did you check happen to miss Min's email from yesterday? If you are
building nonoss you'll need the new vmware SDK for 5.1. Try
downloading the new SDK (~50MB) and building with the new jar.

-- 
Prasanna.,

RE: Master branch build is broken again

Posted by Pradeep Soundararajan <pr...@citrix.com>.
It is broken. We are getting this error only in master branch.

Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.2.0-SNAPSHOT: Failure to find com.cloud.com.vmware:vmware-vim25:jar:5.1 in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

Thanks,
Pradeep S

-----Original Message-----
From: Alena Prokharchyk [mailto:Alena.Prokharchyk@citrix.com] 
Sent: Tuesday, March 05, 2013 5:53 AM
To: cloudstack-dev@incubator.apache.org
Cc: Nitin Mehta; Abhinandan Prateek; Jayapal Reddy Uradi
Subject: Re: Master branch build is broken again
Importance: High

I've fixed the build with commit 7a54458e172fa325d520970bd0dd84aece61f292.

The problem was caused by the new set of api commands added to the stack:

addIpToNic
removeIpFromNic
listNics

1) The commands were incorrectly represented in commands.properties file - had trailing ";" - and APIDocReader failed to process it
2) gen.toc.py fail was lacking category for this new set of commands. I've created a new category "Nic" for this matter.

Jayapal, please update the category name if you feel that it doesn't fully reflect the functionality of these commands you've added.


Thanks,
-Alena.


From: Min Chen <mi...@citrix.com>>
Reply-To: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
To: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
Cc: Nitin Mehta <Ni...@citrix.com>>, Abhinandan Prateek <Ab...@citrix.com>>
Subject: Re: Master branch build is broken again

Filed blocker for this build issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-1502. Hope that somebody can pick it up and fix immediately. Merge is blocked again:(

Thanks
-min

On 3/4/13 10:27 AM, "Min Chen" <mi...@citrix.com>> wrote:

Even with Nitin's revert, master still failed with the following error:

Exception in thread "main" java.lang.NumberFormatException: For input
string: ""
at
java.lang.NumberFormatException.forInputString(NumberFormatException.java:
4
8)
at java.lang.Integer.parseInt(Integer.java:470)
at java.lang.Short.parseShort(Short.java:120)
at java.lang.Short.parseShort(Short.java:78)
at com.cloud.api.doc.ApiXmlDocWriter.main(ApiXmlDocWriter.java:147)

[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]


Anybody knows about this?

Thanks
-min

On 3/4/13 10:00 AM, "Alex Huang" <Al...@citrix.com>> wrote:

-1 on this checkin

And this is not a small change.  18 files.  Some large completely new methods checked in.  Changes to the virtual machine state machine.  No unit testing.

I would reject this fix on these problems alone.

--Alex

-----Original Message-----
From: Alex Huang [mailto:Alex.Huang@citrix.com]
Sent: Monday, March 4, 2013 9:56 AM
To: cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>
Cc: Nitin Mehta; Abhinandan Prateek
Subject: RE: Master branch build is broken again Min, You should just revert the commit.
--Alex
> -----Original Message-----
> From: Min Chen [mailto:min.chen@citrix.com]
> Sent: Monday, March 4, 2013 9:51 AM
> To: 
> cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.ap
> ache.org>
> Cc: Nitin Mehta
> Subject: Master branch build is broken again
> Importance: High
>
> Hi there,
>
> I could not compile master after pulling latest code today,  build 
> failed with the following error:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-
> plugin:2.5.1:compile (default-compile) on project cloud-engine-
orchestration:
> Compilation failure [ERROR] /Users/minc/dev/cloud-
>
asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> /a
> pi/db/VMEntityVO.java:[52,7]
> org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not 
> abstract and does not override abstract method getNewSvcOfferingId() 
> in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>
> I checked the commit history, it seems related to commit 
> e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can 
> somebody quickly fix this? This is blocking me from verifying
> CLOUDSTACK-
> 1491 and merge my feature branch vim51_win8.
>
>        Thanks
> -min
>

Re: Master branch build is broken again

Posted by Alena Prokharchyk <Al...@citrix.com>.
I've fixed the build with commit 7a54458e172fa325d520970bd0dd84aece61f292.

The problem was caused by the new set of api commands added to the stack:

addIpToNic
removeIpFromNic
listNics

1) The commands were incorrectly represented in commands.properties file - had trailing ";" - and APIDocReader failed to process it
2) gen.toc.py fail was lacking category for this new set of commands. I've created a new category "Nic" for this matter.

Jayapal, please update the category name if you feel that it doesn't fully reflect the functionality of these commands you've added.


Thanks,
-Alena.


From: Min Chen <mi...@citrix.com>>
Reply-To: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
To: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
Cc: Nitin Mehta <Ni...@citrix.com>>, Abhinandan Prateek <Ab...@citrix.com>>
Subject: Re: Master branch build is broken again

Filed blocker for this build issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-1502. Hope that somebody
can pick it up and fix immediately. Merge is blocked again:(

Thanks
-min

On 3/4/13 10:27 AM, "Min Chen" <mi...@citrix.com>> wrote:

Even with Nitin's revert, master still failed with the following error:

Exception in thread "main" java.lang.NumberFormatException: For input
string: ""
at
java.lang.NumberFormatException.forInputString(NumberFormatException.java:
4
8)
at java.lang.Integer.parseInt(Integer.java:470)
at java.lang.Short.parseShort(Short.java:120)
at java.lang.Short.parseShort(Short.java:78)
at com.cloud.api.doc.ApiXmlDocWriter.main(ApiXmlDocWriter.java:147)

[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed. Process exited with an error: 1
(Exit value: 1) -> [Help 1]


Anybody knows about this?

Thanks
-min

On 3/4/13 10:00 AM, "Alex Huang" <Al...@citrix.com>> wrote:

-1 on this checkin

And this is not a small change.  18 files.  Some large completely new
methods checked in.  Changes to the virtual machine state machine.  No
unit testing.

I would reject this fix on these problems alone.

--Alex

-----Original Message-----
From: Alex Huang [mailto:Alex.Huang@citrix.com]
Sent: Monday, March 4, 2013 9:56 AM
To: cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>
Cc: Nitin Mehta; Abhinandan Prateek
Subject: RE: Master branch build is broken again
Min,
You should just revert the commit.
--Alex
> -----Original Message-----
> From: Min Chen [mailto:min.chen@citrix.com]
> Sent: Monday, March 4, 2013 9:51 AM
> To: cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>
> Cc: Nitin Mehta
> Subject: Master branch build is broken again
> Importance: High
>
> Hi there,
>
> I could not compile master after pulling latest code today,  build
> failed with the following error:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-
> plugin:2.5.1:compile (default-compile) on project cloud-engine-
orchestration:
> Compilation failure [ERROR] /Users/minc/dev/cloud-
>
asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> /a
> pi/db/VMEntityVO.java:[52,7]
> org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
> abstract and does not override abstract method getNewSvcOfferingId()
> in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>
> I checked the commit history, it seems related to commit
> e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> somebody quickly fix this? This is blocking me from verifying
> CLOUDSTACK-
> 1491 and merge my feature branch vim51_win8.
>
>        Thanks
> -min
>

Re: Master branch build is broken again

Posted by Min Chen <mi...@citrix.com>.
Filed blocker for this build issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-1502. Hope that somebody
can pick it up and fix immediately. Merge is blocked again:(

Thanks
-min

On 3/4/13 10:27 AM, "Min Chen" <mi...@citrix.com> wrote:

>Even with Nitin's revert, master still failed with the following error:
>
>Exception in thread "main" java.lang.NumberFormatException: For input
>string: ""
>	at 
>java.lang.NumberFormatException.forInputString(NumberFormatException.java:
>4
>8)
>	at java.lang.Integer.parseInt(Integer.java:470)
>	at java.lang.Short.parseShort(Short.java:120)
>	at java.lang.Short.parseShort(Short.java:78)
>	at com.cloud.api.doc.ApiXmlDocWriter.main(ApiXmlDocWriter.java:147)
>
>[ERROR] Failed to execute goal
>org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
>cloud-apidoc: Command execution failed. Process exited with an error: 1
>(Exit value: 1) -> [Help 1]
>
>
>Anybody knows about this?
>
>Thanks
>-min
>
>On 3/4/13 10:00 AM, "Alex Huang" <Al...@citrix.com> wrote:
>
>>-1 on this checkin
>>
>>And this is not a small change.  18 files.  Some large completely new
>>methods checked in.  Changes to the virtual machine state machine.  No
>>unit testing.   
>>
>>I would reject this fix on these problems alone.
>>
>>--Alex
>>
>>> -----Original Message-----
>>> From: Alex Huang [mailto:Alex.Huang@citrix.com]
>>> Sent: Monday, March 4, 2013 9:56 AM
>>> To: cloudstack-dev@incubator.apache.org
>>> Cc: Nitin Mehta; Abhinandan Prateek
>>> Subject: RE: Master branch build is broken again
>>> 
>>> Min,
>>> 
>>> You should just revert the commit.
>>> 
>>> --Alex
>>> 
>>> > -----Original Message-----
>>> > From: Min Chen [mailto:min.chen@citrix.com]
>>> > Sent: Monday, March 4, 2013 9:51 AM
>>> > To: cloudstack-dev@incubator.apache.org
>>> > Cc: Nitin Mehta
>>> > Subject: Master branch build is broken again
>>> > Importance: High
>>> >
>>> > Hi there,
>>> >
>>> > I could not compile master after pulling latest code today,  build
>>> > failed with the following error:
>>> >
>>> > [ERROR] Failed to execute goal
>>> > org.apache.maven.plugins:maven-compiler-
>>> > plugin:2.5.1:compile (default-compile) on project cloud-engine-
>>> orchestration:
>>> > Compilation failure [ERROR] /Users/minc/dev/cloud-
>>> > 
>>>asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
>>> > /a
>>> > pi/db/VMEntityVO.java:[52,7]
>>> > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
>>> > abstract and does not override abstract method getNewSvcOfferingId()
>>> > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>>> >
>>> > I checked the commit history, it seems related to commit
>>> > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
>>> > somebody quickly fix this? This is blocking me from verifying
>>> > CLOUDSTACK-
>>> > 1491 and merge my feature branch vim51_win8.
>>> >
>>> >        Thanks
>>> > -min
>>> >
>>
>

Re: Master branch build is broken again

Posted by Min Chen <mi...@citrix.com>.
Even with Nitin's revert, master still failed with the following error:

Exception in thread "main" java.lang.NumberFormatException: For input
string: ""
	at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:4
8)
	at java.lang.Integer.parseInt(Integer.java:470)
	at java.lang.Short.parseShort(Short.java:120)
	at java.lang.Short.parseShort(Short.java:78)
	at com.cloud.api.doc.ApiXmlDocWriter.main(ApiXmlDocWriter.java:147)

[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed. Process exited with an error: 1
(Exit value: 1) -> [Help 1]


Anybody knows about this?

Thanks
-min

On 3/4/13 10:00 AM, "Alex Huang" <Al...@citrix.com> wrote:

>-1 on this checkin
>
>And this is not a small change.  18 files.  Some large completely new
>methods checked in.  Changes to the virtual machine state machine.  No
>unit testing.   
>
>I would reject this fix on these problems alone.
>
>--Alex
>
>> -----Original Message-----
>> From: Alex Huang [mailto:Alex.Huang@citrix.com]
>> Sent: Monday, March 4, 2013 9:56 AM
>> To: cloudstack-dev@incubator.apache.org
>> Cc: Nitin Mehta; Abhinandan Prateek
>> Subject: RE: Master branch build is broken again
>> 
>> Min,
>> 
>> You should just revert the commit.
>> 
>> --Alex
>> 
>> > -----Original Message-----
>> > From: Min Chen [mailto:min.chen@citrix.com]
>> > Sent: Monday, March 4, 2013 9:51 AM
>> > To: cloudstack-dev@incubator.apache.org
>> > Cc: Nitin Mehta
>> > Subject: Master branch build is broken again
>> > Importance: High
>> >
>> > Hi there,
>> >
>> > I could not compile master after pulling latest code today,  build
>> > failed with the following error:
>> >
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-compiler-
>> > plugin:2.5.1:compile (default-compile) on project cloud-engine-
>> orchestration:
>> > Compilation failure [ERROR] /Users/minc/dev/cloud-
>> > asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
>> > /a
>> > pi/db/VMEntityVO.java:[52,7]
>> > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
>> > abstract and does not override abstract method getNewSvcOfferingId()
>> > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>> >
>> > I checked the commit history, it seems related to commit
>> > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
>> > somebody quickly fix this? This is blocking me from verifying
>> > CLOUDSTACK-
>> > 1491 and merge my feature branch vim51_win8.
>> >
>> >        Thanks
>> > -min
>> >
>

RE: Master branch build is broken again

Posted by Alex Huang <Al...@citrix.com>.
-1 on this checkin

And this is not a small change.  18 files.  Some large completely new methods checked in.  Changes to the virtual machine state machine.  No unit testing.   

I would reject this fix on these problems alone.

--Alex

> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Monday, March 4, 2013 9:56 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Nitin Mehta; Abhinandan Prateek
> Subject: RE: Master branch build is broken again
> 
> Min,
> 
> You should just revert the commit.
> 
> --Alex
> 
> > -----Original Message-----
> > From: Min Chen [mailto:min.chen@citrix.com]
> > Sent: Monday, March 4, 2013 9:51 AM
> > To: cloudstack-dev@incubator.apache.org
> > Cc: Nitin Mehta
> > Subject: Master branch build is broken again
> > Importance: High
> >
> > Hi there,
> >
> > I could not compile master after pulling latest code today,  build
> > failed with the following error:
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-compiler-
> > plugin:2.5.1:compile (default-compile) on project cloud-engine-
> orchestration:
> > Compilation failure [ERROR] /Users/minc/dev/cloud-
> > asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> > /a
> > pi/db/VMEntityVO.java:[52,7]
> > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
> > abstract and does not override abstract method getNewSvcOfferingId()
> > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
> >
> > I checked the commit history, it seems related to commit
> > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> > somebody quickly fix this? This is blocking me from verifying
> > CLOUDSTACK-
> > 1491 and merge my feature branch vim51_win8.
> >
> >        Thanks
> > -min
> >

Re: Master branch build is broken again

Posted by Nitin Mehta <Ni...@citrix.com>.
My bad. I will revert the commit...

On 04/03/13 11:25 PM, "Alex Huang" <Al...@citrix.com> wrote:

>Min,
>
>You should just revert the commit.
>
>--Alex
>
>> -----Original Message-----
>> From: Min Chen [mailto:min.chen@citrix.com]
>> Sent: Monday, March 4, 2013 9:51 AM
>> To: cloudstack-dev@incubator.apache.org
>> Cc: Nitin Mehta
>> Subject: Master branch build is broken again
>> Importance: High
>> 
>> Hi there,
>> 
>> I could not compile master after pulling latest code today,  build
>>failed with
>> the following error:
>> 
>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
>> plugin:2.5.1:compile (default-compile) on project
>>cloud-engine-orchestration:
>> Compilation failure [ERROR] /Users/minc/dev/cloud-
>> asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/a
>> pi/db/VMEntityVO.java:[52,7]
>> org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
>>abstract
>> and does not override abstract method getNewSvcOfferingId() in
>> com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>> 
>> I checked the commit history, it seems related to commit
>> e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
>> somebody quickly fix this? This is blocking me from verifying
>>CLOUDSTACK-
>> 1491 and merge my feature branch vim51_win8.
>> 
>>        Thanks
>> -min
>> 
>

RE: Master branch build is broken again

Posted by Alex Huang <Al...@citrix.com>.
Min,

You should just revert the commit.

--Alex

> -----Original Message-----
> From: Min Chen [mailto:min.chen@citrix.com]
> Sent: Monday, March 4, 2013 9:51 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Nitin Mehta
> Subject: Master branch build is broken again
> Importance: High
> 
> Hi there,
> 
> I could not compile master after pulling latest code today,  build failed with
> the following error:
> 
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
> plugin:2.5.1:compile (default-compile) on project cloud-engine-orchestration:
> Compilation failure [ERROR] /Users/minc/dev/cloud-
> asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/a
> pi/db/VMEntityVO.java:[52,7]
> org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not abstract
> and does not override abstract method getNewSvcOfferingId() in
> com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
> 
> I checked the commit history, it seems related to commit
> e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> somebody quickly fix this? This is blocking me from verifying CLOUDSTACK-
> 1491 and merge my feature branch vim51_win8.
> 
>        Thanks
> -min
>