[GitHub] [tvm] mikepapadim commented on pull request #8992: Prevent non-docs stages when a PR only modifies docs/

[GitBox <gi...@apache.org>]

mikepapadim commented on pull request #8992:
URL: https://github.com/apache/tvm/pull/8992#issuecomment-918869901


   > @mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:
   > 
   > * whenever a change only modifies `docs/`, we skip all build, unit test, integration test steps
   > 
   > as @Hzfengsy said, we shouldn't ever skip these nodes:
   > 
   > * Sanity Check (this should already be correct in the patch now)
   > * BUILD: GPU
   > * docs: GPU
   > 
   > i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when `changeset "docs/**"` doesn't match). i'm not entirely sure how to do this.
   
   Yes, right now the `changeset` condition is in the stage scope, I will have another look on how to make use of it in `node` scope.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org