You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 21:18:12 UTC
[GitHub] [incubator-superset] villebro commented on pull request #12008: feat(explore-datasource): add new datasource tab to explore view
villebro commented on pull request #12008:
URL: https://github.com/apache/incubator-superset/pull/12008#issuecomment-745573343
This looks awesome! Some comments (will review code separately):
1. I'm not able to replicate @junlincc's error messages reported above. It looks like there's something wrong with the perms and needs `superset init` to be run.
2. I can also confirm the missing scroll on columns and metrics.
3. The dataset name probably doesn't need to show the name on hover (see video below).
4. The dataset options appear even without a click, is this intentional? (see video below where no mouse clicks happen).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org