You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/06 07:36:53 UTC
[GitHub] [spark] pralabhkumar opened a new pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
pralabhkumar opened a new pull request #33917:
URL: https://github.com/apache/spark/pull/33917
### What changes were proposed in this pull request?
spark.history.kerberos.principal can have _HOST , which will be replaced by host canonical address
### Why are the changes needed?
This change is required for user to provide prinicipal _HOST complaint . User don't need to hardcode the History server URL . This is in line with Hiveserver2, livy server and other hadoop components.
### Does this PR introduce _any_ user-facing change?
Yes, users can now add _HOST in the spark.history.kerberos.principal
### How was this patch tested?
unit tests/local testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33917:
URL: https://github.com/apache/spark/pull/33917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914408440
@gaborgsomogyi Thx for your valuable feedback . It really helps to understand things better.
If multiple history servers are running then they need different config because they handle different clusters, right? If 2 history servers are sitting in the same directory then they corrupt the data inside. A good example is when HS does compaction in streaming use-cases.
=> Not exactly , multiple history servers are running on same cluster , its for the purpose of not sending all the users request to one instance of history server (url). Ambari +HDP distribution provides the way to launch multiple Spark history on different machines in same cluster . Note in this case spark.yarn.historyServer.address is still point to one machine only. I think it helps when user query history server (load can be distributed across machines) .
==> Thx for providing information regarding headless keytab . In our case , i think we must have host/node in the principal . However I am not much aware about the keytab without host or with host. Since earlier we had keytab with host , I am trying to replicate the same behavior in new cluster (principal with host). As stated , the same process we used for hiveserver2 and livyserver (princial +host)
Again Thx for your feedback and time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar edited a comment on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar edited a comment on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914307527
@gaborgsomogyi
Thx for reply and suggestion . Here are couple of use cases
1) If the history server goes down and lets say I have to restart on other machine , I need to change the host name everytime . Its better not to hard code it and .
2) If we launch multiple history server on machine (m1 and m2 ) , have to provide two different configuration files with different HOST in spark.history.kerberos.prinicipal.
Also hiveserver2 ,LivyServer use same patter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r704928498
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -32,6 +32,7 @@ import com.google.common.primitives.Longs
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs._
import org.apache.hadoop.mapred.JobConf
+import org.apache.hadoop.security.{SecurityUtil}
Review comment:
One import not use `{}`
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -345,8 +345,9 @@ object HistoryServer extends Logging {
// occur from the keytab.
if (conf.get(History.KERBEROS_ENABLED)) {
// if you have enabled kerberos the following 2 params must be set
- val principalName = conf.get(History.KERBEROS_PRINCIPAL)
- .getOrElse(throw new NoSuchElementException(History.KERBEROS_PRINCIPAL.key))
+ val principalName = SparkHadoopUtil.get.getServerPrincipal(conf
Review comment:
How thrit server handle this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r707355080
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -32,6 +32,7 @@ import com.google.common.primitives.Longs
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs._
import org.apache.hadoop.mapred.JobConf
+import org.apache.hadoop.security.{SecurityUtil}
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703498027
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -147,6 +148,15 @@ private[spark] class SparkHadoopUtil extends Logging {
}
}
+ /**
+ *
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703118302
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -147,6 +148,15 @@ private[spark] class SparkHadoopUtil extends Logging {
}
}
+ /**
+ *
Review comment:
Maybe remove this line or add some description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703118164
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala
##########
@@ -80,6 +82,18 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assertConfigValue(hadoopConf, "fs.s3a.endpoint", null)
}
+ /**
+ * test for _HOST pattern replacement with Server cannonical address
+ */
+ test("server principal with _HOST pattern") {
+ assert(SparkHadoopUtil.get.getServerPrincipal("spark/_HOST@realm.com")
+ === "spark/%s@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName())
+ , s"Mismatch in expected value")
+ assert(SparkHadoopUtil.get.getServerPrincipal("spark/0.0.0.0@realm.com")
+ === "spark/0.0.0.0@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName())
+ , s"Mismatch in expected value")
Review comment:
```suggestion
assert(SparkHadoopUtil.get.getServerPrincipal("spark/_HOST@realm.com")
=== "spark/%s@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName()),
"Mismatch in expected value")
assert(SparkHadoopUtil.get.getServerPrincipal("spark/0.0.0.0@realm.com")
=== "spark/0.0.0.0@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName()),
"Mismatch in expected value")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703497729
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala
##########
@@ -80,6 +82,18 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assertConfigValue(hadoopConf, "fs.s3a.endpoint", null)
}
+ /**
+ * test for _HOST pattern replacement with Server cannonical address
+ */
+ test("server principal with _HOST pattern") {
Review comment:
done
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala
##########
@@ -80,6 +82,18 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assertConfigValue(hadoopConf, "fs.s3a.endpoint", null)
}
+ /**
+ * test for _HOST pattern replacement with Server cannonical address
+ */
+ test("server principal with _HOST pattern") {
+ assert(SparkHadoopUtil.get.getServerPrincipal("spark/_HOST@realm.com")
+ === "spark/%s@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName())
+ , s"Mismatch in expected value")
+ assert(SparkHadoopUtil.get.getServerPrincipal("spark/0.0.0.0@realm.com")
+ === "spark/0.0.0.0@realm.com".format(InetAddress.getLocalHost.getCanonicalHostName())
+ , s"Mismatch in expected value")
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-913927177
I am not sure who's the best person to review .. maybe @gaborgsomogyi and @bersprockets ... ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar edited a comment on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar edited a comment on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914307527
@gaborgsomogyi
Thx for reply and suggestion . Here are couple of use cases
1) If the history server goes down and lets say I have to restart on other machine , I need to change the host name everytime . Its better not to hard code it and .
2) If we launch multiple history server on machine (m1 and m2 ) , have to provide two different configuration files with different HOST in spark.history.kerberos.prinicipal.
Also hiveserver2 ,LivyServer and Hadoop is using the same pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914331337
1. If history server is down then restart is needed. I can be started on another machine but it's absolutely not must.
2. If multiple history servers are running then they need different config because they handle different clusters, right? If 2 history servers are sitting in the same directory then they corrupt the data inside. A good example is when HS does compaction in streaming use-cases.
> Also hiveserver2 ,LivyServer use same patter
Well, somebody already added this pattern but this doesn't convince me that the codebase need to be increased.
If less configuration is super important it's possible to create headless keytabs w/o any code change.
The effect would be the same...
```
Headless keytab
What you call 'headless keytab' is user principal keys. This already makes an assumption that you have
a user principal that corresponds to certain POSIX user it will start services without prompting for password
e.g(smokeuser,hdfs,hbase). Headless principals are not bound to a specific host or node, they have the
syntax: - @ EXAMPLE.COM
For Example: Headless: hdfs-mycluster@EXAMPLE.COM
```
All in all knowing these I'm not against to add it but I personally not intended to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi edited a comment on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi edited a comment on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914331337
1. If history server is down then restart is needed. It can be started on another machine but it's absolutely not must.
2. If multiple history servers are running then they need different config because they handle different clusters, right? If 2 history servers are sitting in the same directory then they corrupt the data inside. A good example is when HS does compaction in streaming use-cases.
> Also hiveserver2 ,LivyServer use same patter
Well, somebody already added this pattern but this doesn't convince me that the codebase need to be increased.
If less configuration is super important it's possible to create headless keytabs w/o any code change.
The effect would be the same...
```
Headless keytab
What you call 'headless keytab' is user principal keys. This already makes an assumption that you have
a user principal that corresponds to certain POSIX user it will start services without prompting for password
e.g(smokeuser,hdfs,hbase). Headless principals are not bound to a specific host or node, they have the
syntax: - @ EXAMPLE.COM
For Example: Headless: hdfs-mycluster@EXAMPLE.COM
```
All in all knowing these I'm not against to add it but I personally not intended to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r703118025
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala
##########
@@ -80,6 +82,18 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assertConfigValue(hadoopConf, "fs.s3a.endpoint", null)
}
+ /**
+ * test for _HOST pattern replacement with Server cannonical address
+ */
+ test("server principal with _HOST pattern") {
Review comment:
Maybe let's add a JIRA prefix in the test title:
```suggestion
test("SPARK-36622: server principal with _HOST pattern") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r707355798
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -345,8 +345,9 @@ object HistoryServer extends Logging {
// occur from the keytab.
if (conf.get(History.KERBEROS_ENABLED)) {
// if you have enabled kerberos the following 2 params must be set
- val principalName = conf.get(History.KERBEROS_PRINCIPAL)
- .getOrElse(throw new NoSuchElementException(History.KERBEROS_PRINCIPAL.key))
+ val principalName = SparkHadoopUtil.get.getServerPrincipal(conf
Review comment:
This PR is only for handling _HOST at the History Server . Therefore this change won't impact thrift server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-913418745
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-915134189
@HyukjinKwon Have done the suggested changes . Please let me know the next steps .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pralabhkumar commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
pralabhkumar commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914307527
@gaborgsomogyi
Thx for reply and suggestion . Here are couple of use cases
1) If the history server goes down and lets say I have to restart on other machine , I need to change the host name everytime . Its better not to hard code it and .
2) If we launch multiple history server on machine (m1 and m2 ) , have to provide two different configuration files with different HOST in spark.history.kerberos.prinicipal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-914082163
@HyukjinKwon thanks for pinging me.
If we have use-case justification this can be added (on server side it may make sense not like https://github.com/apache/spark/pull/10647). I personally can't tell such use-case where this could be useful.
History server is static because users wants to reach it on the same host. If an admin decides to move to another host
then users must be notified somehow.
All in all I'm interested in why an admin has no idea on which host a static history server will be started?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33917:
URL: https://github.com/apache/spark/pull/33917#issuecomment-999952898
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org