[GitHub] nswamy commented on a change in pull request #12848: Fix Batch input issue with Scala Benchmark

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #12848: Fix Batch input issue with Scala Benchmark
URL: https://github.com/apache/incubator-mxnet/pull/12848#discussion_r226003029
 
 

 ##########
 File path: scala-package/infer/src/main/scala/org/apache/mxnet/infer/ImageClassifier.scala
 ##########
 @@ -147,7 +147,7 @@ object ImageClassifier {
     * returned by this method after the use.
     * </p>
     * @param resizedImage     BufferedImage to get pixels from
-    * @param inputImageShape  Input shape; for example for resnet it is (1,3,224,224).
+    * @param inputImageShape  Input shape; for example for resnet it is (3,224,224).
                               Should be same as inputDescriptor shape.
     * @return                 NDArray pixels array
 
 Review comment:
   can you update this doc here to say that it will return a NDArray with shape (1, 3, 224, 224) in NCHW format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services