You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/02/25 05:10:43 UTC
Re: Review Request 15873: Query cancel should stop running MR tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15873/#review35325
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java
<https://reviews.apache.org/r/15873/#comment65785>
We should make this volatile, another thread calling shutdown might otherwise it is not clear when the main thread will know that shutdown has been called.
The calls to the running concurrent queue can establish happens-before relation ship in some cases, but it is not clear that it will establish it between the shutdown and poll.
"All of these collections help avoid Memory Consistency Errors by defining a happens-before relationship between an operation that adds an object to the collection with subsequent operations that access or remove that object." http://docs.oracle.com/javase/tutorial/essential/concurrency/collections.html
- Thejas Nair
On Dec. 30, 2013, 6:57 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15873/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2013, 6:57 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5901
> https://issues.apache.org/jira/browse/HIVE-5901
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, query canceling does not stop running MR job immediately.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 62fc150
> ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1c84523
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ead7b59
>
> Diff: https://reviews.apache.org/r/15873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 15873: Query cancel should stop running MR tasks
Posted by Navis Ryu <na...@nexr.com>.
> On Feb. 25, 2014, 4:10 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 51
> > <https://reviews.apache.org/r/15873/diff/2/?file=404159#file404159line51>
> >
> > We should make this volatile, another thread calling shutdown might otherwise it is not clear when the main thread will know that shutdown has been called.
> >
> > The calls to the running concurrent queue can establish happens-before relation ship in some cases, but it is not clear that it will establish it between the shutdown and poll.
> > "All of these collections help avoid Memory Consistency Errors by defining a happens-before relationship between an operation that adds an object to the collection with subsequent operations that access or remove that object." http://docs.oracle.com/javase/tutorial/essential/concurrency/collections.html
> >
It's protected by synchronized keyword. DriverContext contains queues and statuses which should be protected from concurrent access.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15873/#review35325
-----------------------------------------------------------
On Dec. 30, 2013, 6:57 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15873/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2013, 6:57 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5901
> https://issues.apache.org/jira/browse/HIVE-5901
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, query canceling does not stop running MR job immediately.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 62fc150
> ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1c84523
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ead7b59
>
> Diff: https://reviews.apache.org/r/15873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>