You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/27 20:41:00 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5469: Remove test that checks wildly varying system-dependent value
ocket8888 opened a new pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469
## What does this PR (Pull Request) do?
- [x] This PR is not related to any Issue
This PR removes a test from Traffic Monitor that was checking that the machine running the tests was using more than 1MiB of memory - as that was fairly unreliable (particularly when running in GitHub Actions).
## Which Traffic Control components are affected by this PR?
- Traffic Monitor
- CI tests (indirectly)
## What is the best way to verify this PR?
Notice that the tests all pass in GHA checks
## The following criteria are ALL met by this PR
- [x] This PR includes tests
- [x] Documentation is unnecessary
- [x] An update to CHANGELOG.md is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768567988
@ezelkow1 Since you authored this test, do you have any thoughts on removing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ezelkow1 commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768571504
> @ezelkow1 Since you authored this test, do you have any thoughts on removing it?
I did not author this test, I would ask @rob05c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768579308
Well the value is wildly varying, but whether or not it varies above 1MiB is not very wild at all, to be sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #5469: Remove test that checks system-dependent value
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768572151
Ah, gotcha. My mistake, I misremembered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768573957
Yeah, I requested his review, which should (hopefully) get his attention
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ezelkow1 edited a comment on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768571504
> @ezelkow1 Since you authored this test, do you have any thoughts on removing it?
I did not author this test, I would ask @rob05c
The ones I added were merely for the csv and some parsing changes, these are more fundamental tests to TM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #5469: Remove test that checks wildly varying system-dependent value
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5469:
URL: https://github.com/apache/trafficcontrol/pull/5469#issuecomment-768576146
It's been a while, but I think this was just added to make sure the code to get system data worked. I don't _think_ there was a bigger reason or issue than that.
I won't object to its removal.
Though I do disagree with the characterization of "system has more than a megabyte of memory" as "wildly varying system-dependent"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org