You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/04/06 12:55:15 UTC
[GitHub] nifi pull request #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it...
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2609
NIFI-5047 Fixed a bug in PutMongo that prevented it from working if t…
…he mode is insert and the query/query key are not set.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi NIFI-5047
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2609
----
commit 03e3bcf57732bbb94cecbddeab559b1614a16730
Author: Mike Thomsen <mi...@...>
Date: 2018-04-06T12:34:08Z
NIFI-5047 Fixed a bug in PutMongo that prevented it from working if the mode is insert and the query/query key are not set.
----
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2609
That's what the unit test is supposed to provide.
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
mvn install with contrib-check runs fine, tests look good.
+1 ( fwiw)
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2609
I tested this with a unit test and a flow that exercised all three options for PutMongo separately, so it should be good now.
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2609
NP.
---
[GitHub] nifi pull request #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2609
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
I apologize, I miss read it as a test for one thing, not multiple. I missed the top part. Please excuse me
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
Should there be a test for just the INSERT mode that corresponds to the problem too?
---
[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2609
+1, merging to master, thanks @MikeThomsen
---