[GitHub] [solr] hiteshk25 commented on a diff in pull request #1293: SOLR-16593 : Redundant fields are present in the replica object of state.json

["hiteshk25 (via GitHub)" <gi...@apache.org>]

hiteshk25 commented on code in PR #1293:
URL: https://github.com/apache/solr/pull/1293#discussion_r1083142545


##########
solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleCollectionCreateDeleteTest.java:
##########
@@ -104,6 +109,29 @@ public void testCreateAndDeleteThenCreateAgain() throws Exception {
     }
   }
 
+  @Test
+  @SuppressWarnings("unchecked")

Review Comment:
   Would be good to add the test where it verifies all the expected properties. If test sees new property then it fails. So that person can justify any change in future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org