You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/12 23:44:47 UTC
[GitHub] [incubator-kyuubi] wolfboys opened a new pull request, #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
wolfboys opened a new pull request, #2343:
URL: https://github.com/apache/incubator-kyuubi/pull/2343
### _Why are the changes needed?_
close: #2297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2343:
URL: https://github.com/apache/incubator-kyuubi/pull/2343#issuecomment-1097480647
> https://github.com/apache/incubator-kyuubi/blob/a63e811ea49a5a70b8e8b895c29aea740976c6ce/externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala#L102
>
> @zhaomin1423 Should the log here be removed?
It's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #2343:
URL: https://github.com/apache/incubator-kyuubi/pull/2343#issuecomment-1097465205
https://github.com/apache/incubator-kyuubi/blob/a63e811ea49a5a70b8e8b895c29aea740976c6ce/externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala#L102
@zhaomin1423 Should the log here be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2343:
URL: https://github.com/apache/incubator-kyuubi/pull/2343#issuecomment-1097518834
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
URL: https://github.com/apache/incubator-kyuubi/pull/2343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2343: [KYUUBI#2297] HiveEngineEvent toString is not pretty
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2343:
URL: https://github.com/apache/incubator-kyuubi/pull/2343#issuecomment-1097479196
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2343](https://codecov.io/gh/apache/incubator-kyuubi/pull/2343?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a63e811) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a63e811ea49a5a70b8e8b895c29aea740976c6ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a63e811) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head a63e811 differs from pull request most recent head 30cb0fe. Consider uploading reports for the commit 30cb0fe to get more accurate results
```diff
@@ Coverage Diff @@
## master #2343 +/- ##
=========================================
Coverage 62.52% 62.52%
Complexity 69 69
=========================================
Files 355 355
Lines 16908 16908
Branches 2285 2285
=========================================
Hits 10572 10572
Misses 5356 5356
Partials 980 980
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2343?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2343?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a63e811...30cb0fe](https://codecov.io/gh/apache/incubator-kyuubi/pull/2343?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org