You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/07 09:20:15 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #5683: riscv/xtensa: corrent dumpstate xcp size

Ouss4 commented on a change in pull request #5683:
URL: https://github.com/apache/incubator-nuttx/pull/5683#discussion_r820513259



##########
File path: arch/xtensa/src/common/xtensa_dumpstate.c
##########
@@ -288,7 +288,7 @@ void xtensa_dumpstate(void)
   if (CURRENT_REGS)
     {
       memcpy(rtcb->xcp.regs,
-             (uintptr_t *)CURRENT_REGS, XCPTCONTEXT_REGS);
+             (uintptr_t *)CURRENT_REGS, 4 * XCPTCONTEXT_REGS);

Review comment:
       ```suggestion
                (uintptr_t *)CURRENT_REGS, XCPTCONTEXT_SIZE);
   ```
   Wouldn't `XCPTCONTEXT_SIZE` be a better choice? It should work the same way and be similar to other architectures.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org