[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3403: Set finished time for GC cycles even if Exception

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3403:
URL: https://github.com/apache/accumulo/pull/3403#discussion_r1195472077


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/gc/GarbageCollectorStats.java:
##########
@@ -52,6 +52,6 @@ public GarbageCollectorStats(String type, GcCycleStats thriftStats) {
     this.inUse = thriftStats.inUse;
     this.deleted = thriftStats.deleted;
     this.errors = thriftStats.errors;
-    this.duration = this.finished - thriftStats.started;
+    this.duration = thriftStats.finished - thriftStats.started;

Review Comment:
   This change isn't a functional one... it just makes it more clear that they're both coming from the same source when computing the difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org