You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/21 00:24:44 UTC

[GitHub] [trafficserver] ywkaras commented on a change in pull request #7281: Make s3_auth plugin auto reload the config at expiration time

ywkaras commented on a change in pull request #7281:
URL: https://github.com/apache/trafficserver/pull/7281#discussion_r508917812



##########
File path: plugins/s3_auth/s3_auth.cc
##########
@@ -876,7 +953,13 @@ event_handler(TSCont cont, TSEvent event, void *edata)
   switch (event) {
   case TS_EVENT_HTTP_SEND_REQUEST_HDR:
     if (request.initialize()) {
-      status = request.authorize(s3);
+      while (true) {

Review comment:
       Why is this busy waiting desirable, especially since it seems to be redundant with the mutex.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org