You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2015/11/01 01:29:29 UTC

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/9297#issuecomment-152783164
  
    > I was thinking adding a toJson method to the SparkListenerEvent.
    
    I'm not a big fan of allowing events to write custom serialization code. I think a better approach would be to change `JsonProtocol` to use Jackson when the event doesn't match any of the currently known event types. Then later we could add a flag that makes `JsonProtocol` use Jackson for all event types.
    
    Mostly that's for backwards compatibility, so that event that are currently written to the event log don't change format. We can then document that the old format is deprecated and will be switched to the new, Jackson-based one in a future release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org