You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/04/27 03:46:25 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #19138: [enhancement](stats) Optimize stats pre-load logic
Kikyou1997 opened a new pull request, #19138:
URL: https://github.com/apache/doris/pull/19138
1. Don't do pre-load until stats table gets ready
2. Don't put pre-loaded unknown stats to cache
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #19138:
URL: https://github.com/apache/doris/pull/19138#discussion_r1178742002
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -146,6 +147,14 @@ public void preHeat() {
private void doPreHeat() {
List<ResultRow> recentStatsUpdatedCols = null;
long retryTimes = 0;
+ while (!StatisticsUtil.statsTblAvailable()) {
Review Comment:
if the statsTbl is not available for a long time, does doPreHeat block fe start up?
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -194,6 +203,9 @@ public Optional<ColumnStatistic> join() {
return Optional.of(c);
}
};
+ if (c == ColumnStatistic.UNKNOWN) {
Review Comment:
I think we should not save Unknown stats into statsTable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #19138:
URL: https://github.com/apache/doris/pull/19138#issuecomment-1524793421
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19138:
URL: https://github.com/apache/doris/pull/19138#issuecomment-1524998462
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19138:
URL: https://github.com/apache/doris/pull/19138#issuecomment-1524998389
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on code in PR #19138:
URL: https://github.com/apache/doris/pull/19138#discussion_r1178743058
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -194,6 +203,9 @@ public Optional<ColumnStatistic> join() {
return Optional.of(c);
}
};
+ if (c == ColumnStatistic.UNKNOWN) {
Review Comment:
why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly merged pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly merged PR #19138:
URL: https://github.com/apache/doris/pull/19138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19138:
URL: https://github.com/apache/doris/pull/19138#issuecomment-1524998376
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #19138:
URL: https://github.com/apache/doris/pull/19138#discussion_r1178747990
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -194,6 +203,9 @@ public Optional<ColumnStatistic> join() {
return Optional.of(c);
}
};
+ if (c == ColumnStatistic.UNKNOWN) {
Review Comment:
Ok, I got your idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on code in PR #19138:
URL: https://github.com/apache/doris/pull/19138#discussion_r1178742774
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -146,6 +147,14 @@ public void preHeat() {
private void doPreHeat() {
List<ResultRow> recentStatsUpdatedCols = null;
long retryTimes = 0;
+ while (!StatisticsUtil.statsTblAvailable()) {
Review Comment:
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19138:
URL: https://github.com/apache/doris/pull/19138#issuecomment-1524998471
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #19138: [enhancement](stats) Optimize stats pre-load logic
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on code in PR #19138:
URL: https://github.com/apache/doris/pull/19138#discussion_r1178744646
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -194,6 +203,9 @@ public Optional<ColumnStatistic> join() {
return Optional.of(c);
}
};
+ if (c == ColumnStatistic.UNKNOWN) {
Review Comment:
There're too many reasons to cause it be unknown even it actually exists, I think we should passively handle unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org