[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4147: Add upper lower bounds

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4147: Add upper lower bounds
URL: https://github.com/apache/incubator-pinot/pull/4147#discussion_r277074035
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spi/model/TimeSeries.java
 ##########
 @@ -53,17 +53,47 @@ public void addPredictedBaseline(DoubleSeries baselineValues) {
     this.df.addSeries(DataFrameUtils.COL_VALUE, baselineValues);
   }
 
+  /**
+   * Add the predicted upper bound into the timeseries
+   * @param upperBoundValues predicted upper bound values
+   */
+  public void addPredictedUpperBound(DoubleSeries upperBoundValues) {
 
 Review comment:
   I'd prefer we have a time series builder class to construct the TimeSeries class. Something like:
   
   ` Public static class Builder() { `
           `  public Builder(LongSeries timeStamp, DoubleSeries currentTimeSeries, DoubleSeries predictedBaseline); `
          `   public Builder upperBound(DoubleSeries predictedUpperBound);`
          `   public Builder lowerBound(DoubleSeries predictedLowerBound);`
          ` .  public TimeSeries Build();`
   `   }
   `
   Then the DataFrame class won't be exposed to client and we have a explicit contract to build TimeSeries instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org