You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/11 15:33:57 UTC
[GitHub] [kafka] mimaison opened a new pull request, #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
mimaison opened a new pull request, #12504:
URL: https://github.com/apache/kafka/pull/12504
@mumrah @cmccabe
It looks like a way to fix `DynamicBrokerReconfigurationTest` in 3.2 is to backport https://github.com/apache/kafka/commit/9c3f605fc78f297ecf5accdcdec18471c19cf7d6. I think it makes sense to to also backport https://github.com/apache/kafka/commit/78038bca6688ce01f7df238d53142f5de3455863, otherwise `testKeyStoreAlter()` is really flaky.
Before I push to 3.2, I want you to take a look and confirm if this makes sense.
### **Please do not merge this PR, instead I'll rebase directly the commits as we don't want to squash them.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
Posted by GitBox <gi...@apache.org>.
mumrah commented on PR #12504:
URL: https://github.com/apache/kafka/pull/12504#issuecomment-1227244915
Thanks @mimaison, the cherry-picks LGTM. I also made a small de-flake attempt for DynamicBrokerReconfigurationTest as part of enabling these tests in KRaft mode.
https://github.com/apache/kafka/pull/12483/files#diff-b61a84891750b610bdef31de49c519f2a61bc4c93c593fb7f777ba0a7825b4f3R497-R504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison closed pull request #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
Posted by GitBox <gi...@apache.org>.
mimaison closed pull request #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
URL: https://github.com/apache/kafka/pull/12504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #12504:
URL: https://github.com/apache/kafka/pull/12504#issuecomment-1224110047
@cmccabe @mumrah Can you take a look at this and confirm this makes sense? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #12504: KAFKA-14149: Fix DynamicBrokerReconfigurationTest in 3.2
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #12504:
URL: https://github.com/apache/kafka/pull/12504#issuecomment-1227307255
Awesome, I'll update the 3.2 branch, thanks!
I'll see if I can grab your commit too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org