You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sateesh Chodapuneedi <sa...@citrix.com> on 2013/04/19 10:32:50 UTC
Re: Review Request: CLOUDSTACK-1786: While reserving IPs in guest network,
if guestvmcidr is a subset of network cidr but not a subset of cidr,
exception is thrown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10084/#review19445
-----------------------------------------------------------
Ship it!
Lookd good to me!
- Sateesh Chodapuneedi
On March 22, 2013, 11:40 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10084/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 11:40 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> The following scenario:
>
> networkcidr: 10.1.1.0/24
>
> cidr: 10.1.1.224/27
>
> Applying reservation with guestvmcidr: 10.1.1.0/26 results in exception:
> Invalid value of Guest VM CIDR. For IP Reservation, Guest VM CIDR should be a subset of network CIDR: 10.1.1.224/27
>
> Expected behavior:
> Reservation should happen and new cidr should be 10.1.1.0/26
>
>
> This addresses bug CLOUDSTACK-1786.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 8303b0b
>
> Diff: https://reviews.apache.org/r/10084/diff/
>
>
> Testing
> -------
>
> Manually tested the scenario, reservation occurs and cidr becomes 10.1.1.0/26
>
>
> Thanks,
>
> Saksham Srivastava
>
>