You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/03 13:03:40 UTC

[GitHub] [mynewt-nimble] sjanc opened a new pull request #716: Random fixes for issues found by static analysis

sjanc opened a new pull request #716: Random fixes for issues found by static analysis 
URL: https://github.com/apache/mynewt-nimble/pull/716
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #716: Random fixes for issues found by static analysis

Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #716: Random fixes for issues found by static analysis 
URL: https://github.com/apache/mynewt-nimble/pull/716#discussion_r362848112
 
 

 ##########
 File path: nimble/drivers/nrf52/src/ble_phy.c
 ##########
 @@ -432,7 +432,7 @@ ble_phy_rxpdu_copy(uint8_t *dptr, struct os_mbuf *rxpdu)
     om = rxpdu;
     dst = om->om_data;
 
-    while (om) {
 
 Review comment:
   we have same thing for nrf51  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc merged pull request #716: Random fixes for issues found by static analysis

Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #716: Random fixes for issues found by static analysis 
URL: https://github.com/apache/mynewt-nimble/pull/716
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services