You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/07/14 15:49:46 UTC

[Impala-ASF-CR] IMPALA-11342: Fix class loading in Hive UDFs' constructors

Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )

Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java:

http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@32
PS1, Line 32:   String member_;
nit: private?


http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java:

http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java@30
PS1, Line 30:   String member_;
nit: private



-- 
To view, visit http://gerrit.cloudera.org:8080/18611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24
Gerrit-Change-Number: 18611
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 15:49:46 +0000
Gerrit-HasComments: Yes