You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/03 18:44:49 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #3650: Pr otg

davids5 opened a new pull request #3650:
URL: https://github.com/apache/incubator-nuttx/pull/3650


   ## Summary
   
   Allows one to Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
   		cases to reuse this GPIO pin and ensure it is not set incorrectly during OS boot.
   ## Impact
   
   none - behing a Knob
   
   ## Testing
   
   PX4 fmu_v5
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3650: stm32{H7|F7} Disables/Enabled the use of GPIO_OTG_ID pin

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3650:
URL: https://github.com/apache/incubator-nuttx/pull/3650#issuecomment-832568149


   @antmerlino Per our discussion I added following text to the commit message.
   
   ```
   stm32h7:Allow for reuse of the OTG_ID GPIO
   
       Currently Nuttx doesn't seem to be any real support for OTG.
       In the future when OTG is supported. This Knob can be removed
       and drivers can enable their pin sets based on CONFIG_OTG.
       (Adding CONFIG_OTG at this time would be misleading.)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3650: stm32{H7|F7} Disables/Enabled the use of GPIO_OTG_ID pin

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3650:
URL: https://github.com/apache/incubator-nuttx/pull/3650#issuecomment-831548386


   @antmerlino - I see your point. The STM32 uses USBDEV lit to disable it. But that seams to be an anti-pattern. What you suggesting is much better, but also not anchored to anything yet.  Really the pin selection and adornment needs to be driven by the board. But these pins do not carry alts so that can not be done at this time. So this seamed like the "least bad" option. Given that it is also LS only. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] antmerlino merged pull request #3650: stm32{H7|F7} Disables/Enabled the use of GPIO_OTG_ID pin

Posted by GitBox <gi...@apache.org>.
antmerlino merged pull request #3650:
URL: https://github.com/apache/incubator-nuttx/pull/3650


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org