You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by "Hari Shreedharan (JIRA)" <ji...@apache.org> on 2016/07/08 22:38:11 UTC

[jira] [Commented] (FLUME-2941) Integrate checkstyle for test classes

    [ https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368610#comment-15368610 ] 

Hari Shreedharan commented on FLUME-2941:
-----------------------------------------

+1. Please go ahead and commit!

> Integrate checkstyle for test classes
> -------------------------------------
>
>                 Key: FLUME-2941
>                 URL: https://issues.apache.org/jira/browse/FLUME-2941
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Lior Zeno
>            Assignee: Mike Percy
>            Priority: Minor
>             Fix For: v1.7.0
>
>
> We should add the maven-checkstyle-plugin to the build process. This plugin can fail a build if the code does not honor the style of our project. This way we can make sure that we have one common style in the code. In addition, reviewers can focus on design, correctness, performance and other important coding aspects other than style issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)