[jira] [Commented] (OPENNLP-632) Improve the stream handling in the EntityLinkerProperties constructors

["Mark Giaconia (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871990#comment-13871990 ] 

Mark Giaconia commented on OPENNLP-632:
---------------------------------------

Made the following changes, mush better now I think.. Take a look when you get a chance to validate.
Stream no longer closed in constructor takes InputStream, try catch used in constuctor that takes File, both methods no longer throw FileNotFoundExc. Class level input stream removed (was never needed), setPropsFileLoc method removed, default constructor removed.

> Improve the stream handling in the EntityLinkerProperties constructors
> ----------------------------------------------------------------------
>
>                 Key: OPENNLP-632
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-632
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Entity Linker
>            Reporter: Joern Kottmann
>            Assignee: Mark Giaconia
>
> The stream handling in the various constructors should be improved.
> The constructor taking an InputStream should not close it, that is the responsibility of the caller. The constructor taking a File object should use a try catch statement to ensure the stream is closed even when loading the property file fails. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)