You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/26 17:38:29 UTC
[GitHub] [superset] geido opened a new pull request #12773: chore: Tabs title empty when new tab
geido opened a new pull request #12773:
URL: https://github.com/apache/superset/pull/12773
### SUMMARY
Closes roadmap item https://github.com/apache-superset/superset-roadmap/issues/143
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
## BEFORE
## AFTER
https://www.awesomescreenshot.com/video/2520803?key=9c174ace8baac140d8e2a4c0f3c7af79
### TEST PLAN
1. Create a Dashboard
2. Create a new tab
3. Click on the tab title
4. It should be empty with a placeholder "Tab title"
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #12773:
URL: https://github.com/apache/superset/pull/12773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (b034398) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `21.11%`.
> The diff coverage is `48.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
===========================================
- Coverage 63.13% 42.01% -21.12%
===========================================
Files 1022 477 -545
Lines 50032 17175 -32857
Branches 4915 4447 -468
===========================================
- Hits 31587 7216 -24371
+ Misses 18245 9959 -8286
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `42.01% <48.00%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `20.00% <ø> (-80.00%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `34.73% <23.07%> (-27.17%)` | :arrow_down: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `45.20% <72.72%> (-29.80%)` | :arrow_down: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `60.00% <100.00%> (-6.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [945 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...b034398](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on a change in pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on a change in pull request #12773:
URL: https://github.com/apache/superset/pull/12773#discussion_r574156567
##########
File path: superset-frontend/src/components/EditableTitle.tsx
##########
@@ -23,28 +23,33 @@ import TooltipWrapper from './TooltipWrapper';
interface EditableTitleProps {
canEdit?: boolean;
+ editing?: boolean;
emptyText?: string;
extraClasses?: Array<string> | string;
multiLine?: boolean;
noPermitTooltip?: string;
onSaveTitle: (arg0: string) => {};
showTooltip?: boolean;
style?: object;
- title: string;
+ title?: string;
+ defaultTitle?: string;
+ placeholder?: string;
}
export default function EditableTitle({
canEdit = false,
- emptyText,
+ editing = false,
extraClasses,
multiLine = false,
noPermitTooltip,
onSaveTitle,
showTooltip = true,
style,
- title,
+ title = '',
+ defaultTitle = '',
+ placeholder = '',
Review comment:
they serve the same purpose right from the UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768595719
Hello @adam-stasiak the placeholder is 'Tab title' already. I assume you are referring to the default title 'New tab'. Do we want also that to be 'Tab title'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-769317782
Fixing the Cypress issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (33e6465) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.79%`.
> The diff coverage is `78.57%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.93% +3.79%
==========================================
Files 1022 1022
Lines 50032 50126 +94
Branches 4915 5201 +286
==========================================
+ Hits 31587 33550 +1963
+ Misses 18245 16445 -1800
+ Partials 200 131 -69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <75.00%> (?)` | |
| javascript | `61.72% <53.57%> (+0.04%)` | :arrow_up: |
| python | `63.95% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `75.30% <71.42%> (+0.30%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <84.61%> (+12.83%)` | :arrow_up: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.54% <100.00%> (+7.87%)` | :arrow_up: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...33e6465](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `0.23%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
- Coverage 63.13% 62.89% -0.24%
==========================================
Files 1022 1022
Lines 50032 50033 +1
Branches 4915 4917 +2
==========================================
- Hits 31587 31470 -117
- Misses 18245 18363 +118
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.70% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `66.66% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `73.97% <80.00%> (-1.03%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768468701
We discussed behavior with @junlincc and some tweaks are needed:
- placeholder should be 'Tab title'
- when we add another tab we should switch to new tab in edit mode - that means user does not have to click anything to start typing - according to: ```Clicking the plus button should bring you into an empty input with "Tab title" as placeholder text, so you can start typing immediately.```
@mihir174 Could you think about this and confirm it is the thing we want. In other place in our application (SQL editor) when we add a new tab we are not in edition mode - but it is a little bit different case. While editing dashboard I assume we want to name our tab when we add this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12773:
URL: https://github.com/apache/superset/pull/12773#discussion_r574150926
##########
File path: superset-frontend/src/components/EditableTitle.tsx
##########
@@ -23,28 +23,33 @@ import TooltipWrapper from './TooltipWrapper';
interface EditableTitleProps {
canEdit?: boolean;
+ editing?: boolean;
emptyText?: string;
extraClasses?: Array<string> | string;
multiLine?: boolean;
noPermitTooltip?: string;
onSaveTitle: (arg0: string) => {};
showTooltip?: boolean;
style?: object;
- title: string;
+ title?: string;
+ defaultTitle?: string;
+ placeholder?: string;
}
export default function EditableTitle({
canEdit = false,
- emptyText,
+ editing = false,
extraClasses,
multiLine = false,
noPermitTooltip,
onSaveTitle,
showTooltip = true,
style,
- title,
+ title = '',
+ defaultTitle = '',
+ placeholder = '',
Review comment:
Do we need both defaultTitle AND placeholder, or could these share a common purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `0.23%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
- Coverage 63.13% 62.90% -0.24%
==========================================
Files 1022 1022
Lines 50032 50018 -14
Branches 4915 4917 +2
==========================================
- Hits 31587 31463 -124
- Misses 18245 18355 +110
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.71% <ø> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `66.66% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `73.97% <80.00%> (-1.03%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (b034398) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `21.49%`.
> The diff coverage is `48.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
===========================================
- Coverage 63.13% 41.64% -21.50%
===========================================
Files 1022 477 -545
Lines 50032 17175 -32857
Branches 4915 4447 -468
===========================================
- Hits 31587 7152 -24435
+ Misses 18245 10023 -8222
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `41.64% <48.00%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `20.00% <ø> (-80.00%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `34.73% <23.07%> (-27.17%)` | :arrow_down: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `45.20% <72.72%> (-29.80%)` | :arrow_down: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `60.00% <100.00%> (-6.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [945 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...b034398](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mihir174 commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
mihir174 commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-773477938
@junlincc no standard for this yet, can you pls add a des-system-revisit label?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.80%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.93% +3.80%
==========================================
Files 1022 1022
Lines 50032 50052 +20
Branches 4915 4917 +2
==========================================
+ Hits 31587 33504 +1917
+ Misses 18245 16424 -1821
+ Partials 200 124 -76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <60.00%> (?)` | |
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.99% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.07% <ø> (+7.40%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `76.71% <80.00%> (+1.71%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.50% <0.00%> (-0.66%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.35% <0.00%> (-0.32%)` | :arrow_down: |
| ... and [187 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `0.25%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
- Coverage 63.13% 62.88% -0.26%
==========================================
Files 1022 1022
Lines 50032 50018 -14
Branches 4915 4917 +2
==========================================
- Hits 31587 31453 -134
- Misses 18245 18365 +120
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.68% <ø> (-0.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `66.66% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `73.97% <80.00%> (-1.03%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768041257
is it the same color we use in other placeholders in Superset?
@mihir174 do we have a standard for placeholder text color?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.56%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.70% +3.56%
==========================================
Files 1022 1022
Lines 50032 50052 +20
Branches 4915 4917 +2
==========================================
+ Hits 31587 33385 +1798
+ Misses 18245 16539 -1706
+ Partials 200 128 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.50% <60.00%> (?)` | |
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.07% <ø> (+7.40%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `76.71% <80.00%> (+1.71%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767748165
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
simcha90 commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-779390572
👍 Hi @geido thanks for PR it looks good changes, I just found some buggy behavior, can you look please:
https://user-images.githubusercontent.com/56388545/107982543-e91dfc00-6fcc-11eb-99d9-3986b30f00ad.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `2.68%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 65.82% +2.68%
==========================================
Files 1022 1022
Lines 50032 50052 +20
Branches 4915 4917 +2
==========================================
+ Hits 31587 32946 +1359
+ Misses 18245 16970 -1275
+ Partials 200 136 -64
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `42.85% <60.00%> (?)` | |
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `66.66% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `73.97% <80.00%> (-1.03%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [...frontend/src/components/SupersetResourceSelect.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC50c3g=) | `67.74% <0.00%> (-2.26%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| ... and [156 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12773:
URL: https://github.com/apache/superset/pull/12773#discussion_r574316992
##########
File path: superset-frontend/src/components/EditableTitle.tsx
##########
@@ -23,28 +23,33 @@ import TooltipWrapper from './TooltipWrapper';
interface EditableTitleProps {
canEdit?: boolean;
+ editing?: boolean;
emptyText?: string;
extraClasses?: Array<string> | string;
multiLine?: boolean;
noPermitTooltip?: string;
onSaveTitle: (arg0: string) => {};
showTooltip?: boolean;
style?: object;
- title: string;
+ title?: string;
+ defaultTitle?: string;
+ placeholder?: string;
}
export default function EditableTitle({
canEdit = false,
- emptyText,
+ editing = false,
extraClasses,
multiLine = false,
noPermitTooltip,
onSaveTitle,
showTooltip = true,
style,
- title,
+ title = '',
+ defaultTitle = '',
+ placeholder = '',
Review comment:
@junlincc @rusackas the component is used by several others. In order to safely apply these changes to the tabs titles only, a separation between title and defaultTitle needs to be made. If we want to change them all in the future, this can be consolidated and one of the two removed. That is not the case now though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido removed a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido removed a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-769317782
Fixing the Cypress issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.65%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.78% +3.65%
==========================================
Files 1022 1022
Lines 50032 50052 +20
Branches 4915 4917 +2
==========================================
+ Hits 31587 33428 +1841
+ Misses 18245 16500 -1745
+ Partials 200 124 -76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <60.00%> (?)` | |
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.07% <ø> (+7.40%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `76.71% <80.00%> (+1.71%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-769273520
@adam-stasiak @junlincc I have updated the video to show the new behavior. Please have a look. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (33e6465) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.55%`.
> The diff coverage is `78.57%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.69% +3.55%
==========================================
Files 1022 1022
Lines 50032 50126 +94
Branches 4915 5201 +286
==========================================
+ Hits 31587 33430 +1843
+ Misses 18245 16561 -1684
+ Partials 200 135 -65
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.61% <75.00%> (?)` | |
| javascript | `61.72% <53.57%> (+0.04%)` | :arrow_up: |
| python | `63.69% <ø> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `75.30% <71.42%> (+0.30%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <84.61%> (+12.83%)` | :arrow_up: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.54% <100.00%> (+7.87%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [210 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...33e6465](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-780034803
Hello @simcha90 I can reproduce the same problem on master. This does not look related to my changes. I have created a separate issue #13158. Thanks for reporting it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768865672
@adam-stasiak thank you for testing!
@geido yes,
1. once a new tab is created, the underline should goes under the new tab
2. let's set both label and place holder "Tab title", it's probably more actionable
3. I also notice there is tooltip when hovering on the input. i think changing tab name is pretty self-explanatory, so let's remove it.
<img width="383" alt="Screen Shot 2021-01-27 at 11 42 26 PM" src="https://user-images.githubusercontent.com/67837651/106105901-95b93c00-60f9-11eb-96cf-c8eca2855b87.png">
Thank you both! 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12773:
URL: https://github.com/apache/superset/pull/12773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-773821107
> no standard for this yet, can you pls add a des-system-revisit label?
added label! thanks Mihir for being on top of PRs! @mihir174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-781364954
Thanks @rusackas. I'll also take a note of that and we can tackle it as soon as we want to apply the enhancement globally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12773: chore: Tabs title empty when new tab
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (4e4b76f) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **decrease** coverage by `1.45%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
- Coverage 63.13% 61.67% -1.46%
==========================================
Files 1022 534 -488
Lines 50032 19916 -30116
Branches 4915 4917 +2
==========================================
- Hits 31587 12284 -19303
+ Misses 18245 7432 -10813
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.67% <80.00%> (-0.01%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `66.66% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `73.97% <80.00%> (-1.03%)` | :arrow_down: |
| [...ns/versions/4451805bbaa1\_remove\_double\_percents.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NDUxODA1YmJhYTFfcmVtb3ZlX2RvdWJsZV9wZXJjZW50cy5weQ==) | | |
| [superset/reports/notifications/exceptions.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2V4Y2VwdGlvbnMucHk=) | | |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | | |
| [.../e557699a813e\_add\_tables\_relation\_to\_row\_level\_.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNTU3Njk5YTgxM2VfYWRkX3RhYmxlc19yZWxhdGlvbl90b19yb3dfbGV2ZWxfLnB5) | | |
| [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | | |
| [...df208545\_migrate\_time\_range\_for\_default\_filters.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Y2U4ZGYyMDg1NDVfbWlncmF0ZV90aW1lX3JhbmdlX2Zvcl9kZWZhdWx0X2ZpbHRlcnMucHk=) | | |
| ... and [481 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...4e4b76f](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-773821107
> no standard for this yet, can you pls add a des-system-revisit label?
added label! thanks Mihir for being on top of PRs! @mihir174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mihir174 commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
mihir174 commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-773477938
@junlincc no standard for this yet, can you pls add a des-system-revisit label?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768468701
We discussed behavior with @junlincc and some tweaks are needed:
- placeholder should be 'Tab title'
- when we add another tab we should switch to new tab in edit mode - that means user does not have to click anything to start typing - according to: ```Clicking the plus button should bring you into an empty input with "Tab title" as placeholder text, so you can start typing immediately.```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (33e6465) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.79%`.
> The diff coverage is `78.57%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.93% +3.79%
==========================================
Files 1022 1022
Lines 50032 50126 +94
Branches 4915 5201 +286
==========================================
+ Hits 31587 33551 +1964
+ Misses 18245 16444 -1801
+ Partials 200 131 -69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <75.00%> (?)` | |
| javascript | `61.72% <53.57%> (+0.04%)` | :arrow_up: |
| python | `63.95% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `75.30% <71.42%> (+0.30%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <84.61%> (+12.83%)` | :arrow_up: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.54% <100.00%> (+7.87%)` | :arrow_up: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| ... and [207 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...33e6465](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-767784620
# [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=h1) Report
> Merging [#12773](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=desc) (33e6465) into [master](https://codecov.io/gh/apache/superset/commit/017f11f9d84ac88019a6c42eb65a67b617966e95?el=desc) (017f11f) will **increase** coverage by `3.64%`.
> The diff coverage is `78.57%`.
[](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12773 +/- ##
==========================================
+ Coverage 63.13% 66.77% +3.64%
==========================================
Files 1022 1022
Lines 50032 50126 +94
Branches 4915 5201 +286
==========================================
+ Hits 31587 33473 +1886
+ Misses 18245 16522 -1723
+ Partials 200 131 -69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <75.00%> (?)` | |
| javascript | `61.72% <53.57%> (+0.04%)` | :arrow_up: |
| python | `63.69% <ø> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `75.30% <71.42%> (+0.30%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <84.61%> (+12.83%)` | :arrow_up: |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | `74.54% <100.00%> (+7.87%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [211 more](https://codecov.io/gh/apache/superset/pull/12773/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=footer). Last update [017f11f...33e6465](https://codecov.io/gh/apache/superset/pull/12773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org