You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/18 12:34:04 UTC

[GitHub] eladkal commented on a change in pull request #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator

eladkal commented on a change in pull request #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator
URL: https://github.com/apache/incubator-airflow/pull/4325#discussion_r242519147
 
 

 ##########
 File path: airflow/contrib/operators/sftp_operator.py
 ##########
 @@ -122,7 +122,11 @@ def execute(self, context):
                 self.ssh_hook.remote_host = self.remote_host
 
             with self.ssh_hook.get_conn() as ssh_client:
-                sftp_client = ssh_client.open_sftp()
+                try:
 
 Review comment:
   Currently it raises AirflowException as it's being handled at this line:
   https://github.com/apache/incubator-airflow/blob/c83a4e5b952baa8d390e94d27fd12df888d3113e/airflow/contrib/operators/sftp_operator.py#L158
   
   The propose here is just not to show the "Error while transferring (file_msg)" as this is confusing and file_msg is None.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services