You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/17 23:46:37 UTC

svn commit: r1730963 - in /jmeter/trunk: src/core/org/apache/jmeter/resources/messages.properties src/core/org/apache/jmeter/resources/messages_fr.properties src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java xdocs/changes.xml

Author: pmouawad
Date: Wed Feb 17 22:46:36 2016
New Revision: 1730963

URL: http://svn.apache.org/viewvc?rev=1730963&view=rev
Log:
Bug 59023 - HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6
Bugzilla Id: 59023

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties Wed Feb 17 22:46:36 2016
@@ -1289,7 +1289,7 @@ web_server_timeout_connect=Connect:
 web_server_timeout_response=Response:
 web_server_timeout_title=Timeouts (milliseconds)
 web_testing2_title=HTTP Request HTTPClient
-web_testing_concurrent_download=Use concurrent pool. Size:
+web_testing_concurrent_download=Parallel downloads. Number:
 web_testing_embedded_url_pattern=URLs must match\:
 web_testing_retrieve_images=Retrieve All Embedded Resources
 web_testing_retrieve_title=Embedded Resources from HTML Files

Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties Wed Feb 17 22:46:36 2016
@@ -1274,7 +1274,7 @@ web_server_timeout_connect=Connexion \:
 web_server_timeout_response=R\u00E9ponse \:
 web_server_timeout_title=D\u00E9lai expiration (ms)
 web_testing2_title=Requ\u00EAte HTTP HTTPClient
-web_testing_concurrent_download=Utiliser pool unit\u00E9. Nbre \:
+web_testing_concurrent_download=T\u00E9l\u00E9chargements en parall\u00e8le. Nombre \:
 web_testing_embedded_url_pattern=Les URL \u00E0 inclure doivent correspondre \u00E0 \:
 web_testing_retrieve_images=R\u00E9cup\u00E9rer les ressources incluses
 web_testing_retrieve_title=Ressources incluses dans les pages HTML

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730963&r1=1730962&r2=1730963&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Wed Feb 17 22:46:36 2016
@@ -180,7 +180,7 @@ public abstract class HTTPSamplerBase ex
     
     public static final String CONCURRENT_POOL = "HTTPSampler.concurrentPool"; // $NON-NLS-1$
 
-    private static final String CONCURRENT_POOL_DEFAULT = "4"; // default for concurrent pool (do not change)
+    private static final String CONCURRENT_POOL_DEFAULT = "6"; // default for concurrent pool (do not change)
     
     private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
 

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1730963&r1=1730962&r2=1730963&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Wed Feb 17 22:46:36 2016
@@ -111,6 +111,7 @@ Summary
     <li><bug>59006</bug>Change Default proxy recording port to 8888 to align it with Recording Template. Contributed by Antonio Gomes Rodrigues (ra0077 at gmail.com)</li>
     <li><bug>58099</bug>Performance : Lazily initialize HttpClient SSL Context to avoid its initialization even for HTTP only scenarios</li>
     <li><bug>57577</bug>HttpSampler : Retrieve All Embedded Resources should only compute size or hash by default. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
+    <li><bug>59023</bug>HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
 </ul>
 
 <h3>Other samplers</h3>



Re: svn commit: r1730963 - in /jmeter/trunk: src/core/org/apache/jmeter/resources/messages.properties src/core/org/apache/jmeter/resources/messages_fr.properties src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java xdocs/changes.xml

Posted by sebb <se...@gmail.com>.
On 17 February 2016 at 22:46,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Wed Feb 17 22:46:36 2016
> New Revision: 1730963
>
> URL: http://svn.apache.org/viewvc?rev=1730963&view=rev
> Log:
> Bug 59023 - HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6
> Bugzilla Id: 59023
>
> Modified:
>     jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>     jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>     jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties Wed Feb 17 22:46:36 2016
> @@ -1289,7 +1289,7 @@ web_server_timeout_connect=Connect:
>  web_server_timeout_response=Response:
>  web_server_timeout_title=Timeouts (milliseconds)
>  web_testing2_title=HTTP Request HTTPClient
> -web_testing_concurrent_download=Use concurrent pool. Size:
> +web_testing_concurrent_download=Parallel downloads. Number:
>  web_testing_embedded_url_pattern=URLs must match\:
>  web_testing_retrieve_images=Retrieve All Embedded Resources
>  web_testing_retrieve_title=Embedded Resources from HTML Files
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties Wed Feb 17 22:46:36 2016
> @@ -1274,7 +1274,7 @@ web_server_timeout_connect=Connexion \:
>  web_server_timeout_response=R\u00E9ponse \:
>  web_server_timeout_title=D\u00E9lai expiration (ms)
>  web_testing2_title=Requ\u00EAte HTTP HTTPClient
> -web_testing_concurrent_download=Utiliser pool unit\u00E9. Nbre \:
> +web_testing_concurrent_download=T\u00E9l\u00E9chargements en parall\u00e8le. Nombre \:
>  web_testing_embedded_url_pattern=Les URL \u00E0 inclure doivent correspondre \u00E0 \:
>  web_testing_retrieve_images=R\u00E9cup\u00E9rer les ressources incluses
>  web_testing_retrieve_title=Ressources incluses dans les pages HTML
>
> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Wed Feb 17 22:46:36 2016
> @@ -180,7 +180,7 @@ public abstract class HTTPSamplerBase ex
>
>      public static final String CONCURRENT_POOL = "HTTPSampler.concurrentPool"; // $NON-NLS-1$
>
> -    private static final String CONCURRENT_POOL_DEFAULT = "4"; // default for concurrent pool (do not change)
> +    private static final String CONCURRENT_POOL_DEFAULT = "6"; // default for concurrent pool (do not change)

There was obviously a reason for the "do not change" comment.
Why is it now OK to change the value?

>
>      private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
>
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==============================================================================
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Wed Feb 17 22:46:36 2016
> @@ -111,6 +111,7 @@ Summary
>      <li><bug>59006</bug>Change Default proxy recording port to 8888 to align it with Recording Template. Contributed by Antonio Gomes Rodrigues (ra0077 at gmail.com)</li>
>      <li><bug>58099</bug>Performance : Lazily initialize HttpClient SSL Context to avoid its initialization even for HTTP only scenarios</li>
>      <li><bug>57577</bug>HttpSampler : Retrieve All Embedded Resources should only compute size or hash by default. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
> +    <li><bug>59023</bug>HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
>  </ul>
>
>  <h3>Other samplers</h3>
>
>