You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/21 01:50:58 UTC

[GitHub] [flink] blublinsky opened a new pull request #14439: FLINK-20664 Support setting service account for TaskManager pod

blublinsky opened a new pull request #14439:
URL: https://github.com/apache/flink/pull/14439


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Currently, we only set the service account for JobManager. The TaskManager is using the default service account. Before the KubernetesHAService is introduced, it works because the TaskManager does not need to access the K8s resource(e.g. ConfigMap) directly. But now the TaskManager needs to watch ConfigMap and retrieve leader address. So if the default service account does not have enough permission, users could not specify a valid service account for TaskManager.
   
   
   ## Brief change log
   
   *(for example:)*
     - New configuration parameter TASK_MANAGER_SERVICE_ACCOUNT created
     - Method getServiceAccount added to KubernetesTaskManagerParameters
     - Service account adde to the pod creation in InitTaskManagerDecorator
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
     - The serializers: (yes / no / don't know) no
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) yes, allowing Task manager to run under known account, that can be given required privileges
     - The S3 file system connector: (yes / no / don't know) no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] blublinsky commented on pull request #14439: [FLINK-20664][k8s] Support setting service account for TaskManager pod.

Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-749010462


   Re did


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] blublinsky commented on pull request #14439: [FLINK-20664][k8s] Support setting service account for TaskManager pod.

Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-749078816


   Added unit test
   
   
   > On Dec 20, 2020, at 8:53 PM, Yang Wang <no...@github.com> wrote:
   > 
   > 
   > @blublinsky <https://github.com/blublinsky> Could you please refine the content of this PR? It have too many unrelated changes? Also the commit message also needs to be updated based on the contribution guideline[1]. Maybe it could be [FLINK-20664][k8s] Support setting service account for TaskManager pod.
   > Another important thing is we should add some corresponding unit tests for this change.
   > 
   > [1]. https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions <https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions>
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/flink/pull/14439#issuecomment-748727909>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGA5MG6XU4ASLABMXXNLF2DSV22BFANCNFSM4VDR4O6A>.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] blublinsky closed pull request #14439: [FLINK-20664][k8s] Support setting service account for TaskManager pod.

Posted by GitBox <gi...@apache.org>.
blublinsky closed pull request #14439:
URL: https://github.com/apache/flink/pull/14439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14439: FLINK-20664 Support setting service account for TaskManager pod

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-748714989


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 680de10648d9fcb86caa5963d7965a99ed3b520b (Mon Dec 21 01:57:56 UTC 2020)
   
   **Warnings:**
    * **12 pom.xml files were touched**: Check for build and licensing issues.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14439: FLINK-20664 Support setting service account for TaskManager pod

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-748727909


   @blublinsky Could you please refine the content of this PR? It have too many unrelated changes? Also the commit message also needs to be updated based on the contribution guideline[1]. Maybe it could be `[FLINK-20664][k8s] Support setting service account for TaskManager pod`.
   Another important thing is we should add some corresponding unit tests for this change.
   
   [1]. https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14439: FLINK-20664 Support setting service account for TaskManager pod

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-748719477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 680de10648d9fcb86caa5963d7965a99ed3b520b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14439: FLINK-20664 Support setting service account for TaskManager pod

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-748719477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11087",
       "triggerID" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 680de10648d9fcb86caa5963d7965a99ed3b520b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14439: [FLINK-20664][k8s] Support setting service account for TaskManager pod.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14439:
URL: https://github.com/apache/flink/pull/14439#issuecomment-748719477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11087",
       "triggerID" : "680de10648d9fcb86caa5963d7965a99ed3b520b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 680de10648d9fcb86caa5963d7965a99ed3b520b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org