You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brian Towles via Review Board <no...@reviews.apache.org> on 2018/08/31 15:32:30 UTC
Review Request 68585: SENTRY-2374: Add dependencies for Lombok
development assistance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68585/
-----------------------------------------------------------
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2374
https://issues.apache.org/jira/browse/SENTRY-2374
Repository: sentry
Description
-------
Basic top level pom addition of the lombok libary for use in the compile stage.
Diffs
-----
lombok.config PRE-CREATION
pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
Diff: https://reviews.apache.org/r/68585/diff/1/
Testing
-------
Build and Unit tests.
Thanks,
Brian Towles
Re: Review Request 68585: SENTRY-2374: Add dependencies for Lombok
development assistance
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68585/#review208198
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Aug. 31, 2018, 3:32 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68585/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 3:32 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2374
> https://issues.apache.org/jira/browse/SENTRY-2374
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic top level pom addition of the lombok libary for use in the compile stage.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
>
>
> Diff: https://reviews.apache.org/r/68585/diff/1/
>
>
> Testing
> -------
>
> Build and Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68585: SENTRY-2374: Add dependencies for Lombok
development assistance
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68585/#review208206
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Aug. 31, 2018, 3:32 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68585/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 3:32 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2374
> https://issues.apache.org/jira/browse/SENTRY-2374
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic top level pom addition of the lombok libary for use in the compile stage.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
>
>
> Diff: https://reviews.apache.org/r/68585/diff/1/
>
>
> Testing
> -------
>
> Build and Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 68585: SENTRY-2374: Add dependencies for Lombok
development assistance
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68585/#review208202
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Aug. 31, 2018, 3:32 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68585/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 3:32 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2374
> https://issues.apache.org/jira/browse/SENTRY-2374
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Basic top level pom addition of the lombok libary for use in the compile stage.
>
>
> Diffs
> -----
>
> lombok.config PRE-CREATION
> pom.xml fb9950d0feca18f7f49531c6c38bb7357b565e5b
>
>
> Diff: https://reviews.apache.org/r/68585/diff/1/
>
>
> Testing
> -------
>
> Build and Unit tests.
>
>
> Thanks,
>
> Brian Towles
>
>