You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ryan Rawson <ry...@gmail.com> on 2010/10/06 03:15:49 UTC
Review Request: HBASE-3008 - memstore size can go negative (!) causing data
to be unable to be flushed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/965/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
a problem we observed with HBASE-3008 + HBASE-2997, that memstore sizes can go negative preventing us from flushing them even if there is data within. This is a data loss bug.
This addresses bug HBASE-3008.
http://issues.apache.org/jira/browse/HBASE-3008
Diffs
-----
trunk/CHANGES.txt 1004867
trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1004867
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 1004867
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java 1004867
Diff: http://review.cloudera.org/r/965/diff
Testing
-------
Thanks,
Ryan
Re: Review Request: HBASE-3008 - memstore size can go negative (!) causing
data to be unable to be flushed
Posted by Todd Lipcon <to...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/965/#review1433
-----------------------------------------------------------
Ship it!
thanks for writing these tests
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
<http://review.cloudera.org/r/965/#comment5003>
some short doc explaining what this test is doing would be nice
- Todd
On 2010-10-05 18:15:49, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/965/
> -----------------------------------------------------------
>
> (Updated 2010-10-05 18:15:49)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> a problem we observed with HBASE-3008 + HBASE-2997, that memstore sizes can go negative preventing us from flushing them even if there is data within. This is a data loss bug.
>
>
> This addresses bug HBASE-3008.
> http://issues.apache.org/jira/browse/HBASE-3008
>
>
> Diffs
> -----
>
> trunk/CHANGES.txt 1004867
> trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1004867
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 1004867
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java 1004867
>
> Diff: http://review.cloudera.org/r/965/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: HBASE-3008 - memstore size can go negative (!) causing
data to be unable to be flushed
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/965/#review1434
-----------------------------------------------------------
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
<http://review.cloudera.org/r/965/#comment5007>
yes that is a good point, there is a little bit of crufty comments left here, so i removed them and i also added asserts at the end so the computed and 'computed along' sizes are the same.
- Ryan
On 2010-10-05 18:15:49, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/965/
> -----------------------------------------------------------
>
> (Updated 2010-10-05 18:15:49)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> a problem we observed with HBASE-3008 + HBASE-2997, that memstore sizes can go negative preventing us from flushing them even if there is data within. This is a data loss bug.
>
>
> This addresses bug HBASE-3008.
> http://issues.apache.org/jira/browse/HBASE-3008
>
>
> Diffs
> -----
>
> trunk/CHANGES.txt 1004867
> trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1004867
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 1004867
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java 1004867
>
> Diff: http://review.cloudera.org/r/965/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>