[jira] Resolved: (BUILDR-325) Overriding package spec with classifer doesn't work

["Alex Boisvert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-325.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.5

Patch applied (with minor addition to the spec).  Thanks Antoine!

boisvert@sixtine:~/svn/buildr-325$ svn commit -m "BUILDR-325: Overriding package spec with classifer doesn't work (Antoine Toulme)"
Sending        CHANGELOG
Sending        lib/buildr/packaging/package.rb
Sending        spec/packaging/packaging_spec.rb
Transmitting file data ...
Committed revision 821029.


> Overriding package spec with classifer doesn't work
> ---------------------------------------------------
>
>                 Key: BUILDR-325
>                 URL: https://issues.apache.org/jira/browse/BUILDR-325
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Antoine Toulme
>             Fix For: 1.3.5
>
>         Attachments: buildrpatch, spec_BUILDR-325
>
>
> The current code in package.rb does this:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)
> ie, if you define two packages that use the :zip type, only the first one will be taken into account.
> I happen to work on Eclipse features, in which both the source and original features work with the same type, but have different classifiers.
> So I'd like the code to do this instead:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] && 
>                   (spec[:classifier].nil? || pkg.classifier == spec[:classifier])}) ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.