You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/06/10 13:20:04 UTC

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2696: ARTEMIS-2374 JournalStorageManager::addBytesToLargeMessage leaks ByteBuffer

franz1981 commented on a change in pull request #2696: ARTEMIS-2374 JournalStorageManager::addBytesToLargeMessage leaks ByteBuffer
URL: https://github.com/apache/activemq-artemis/pull/2696#discussion_r292006965
 
 

 ##########
 File path: artemis-server/src/test/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManagerTest.java
 ##########
 @@ -70,6 +77,11 @@
    private static ExecutorService ioExecutor;
    private static ExecutorService testExecutor;
 
+   @Before
+   public void init() {
+      disableCheckThread();
 
 Review comment:
   there is no leak: I'm avoiding to re-create 3/4 threads for each of the test method...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services