You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2021/11/24 14:04:49 UTC
[incubator-kyuubi] 02/03: [KYUUBI #1442] Fix encode MySQLHandshakePacket UT
This is an automated email from the ASF dual-hosted git repository.
feiwang pushed a commit to branch branch-1.4
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
commit 7784ded98b46cad3b45c7d220a449ddb9eb7d73f
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Wed Nov 24 12:12:10 2021 +0800
[KYUUBI #1442] Fix encode MySQLHandshakePacket UT
### _Why are the changes needed?_
Previous the UT depends on `KYUUBI_VERSION`, so bump version casue it to fail.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #1442 from pan3793/fix-mysql-codec.
Closes #1442
ad3901fa [Cheng Pan] Address comments
d17b5b57 [Cheng Pan] Fix encode MySQLHandshakePacket UT
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: fwang12 <fw...@ebay.com>
---
.../mysql/authentication/MySQLAuthPacketSuite.scala | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/authentication/MySQLAuthPacketSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/authentication/MySQLAuthPacketSuite.scala
index 436b94b..704b841 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/authentication/MySQLAuthPacketSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/authentication/MySQLAuthPacketSuite.scala
@@ -31,15 +31,15 @@ class MySQLAuthPacketSuite extends KyuubiFunSuite with MySQLCodecHelper {
}
test("encode MySQLHandshakePacket") {
- val packet = MySQLHandshakePacket(2, authPluginData)
+ val packet = new MySQLHandshakePacket(2, authPluginData) {
+ override def serverVersion: String = "dummy"
+ }
val expected = decodeHex(
- """0a 35 2e 37 2e 32 32 2d 4b 79 75 75 62 69 2d 53
- |65 72 76 65 72 20 31 2e 34 2e 30 2d 53 4e 41 50
- |53 48 4f 54 00 02 00 00 00 77 37 34 35 45 51 55
- |65 00 4f b7 2d 02 00 08 00 15 00 00 00 00 00 00
- |00 00 00 00 69 44 57 32 44 44 33 4e 6d 36 69 74
- |00 6d 79 73 71 6c 5f 6e 61 74 69 76 65 5f 70 61
- |73 73 77 6f 72 64 00
+ """0a 64 75 6d 6d 79 00 02 00 00 00 77 37 34 35 45
+ |51 55 65 00 4f b7 2d 02 00 08 00 15 00 00 00 00
+ |00 00 00 00 00 00 69 44 57 32 44 44 33 4e 6d 36
+ |69 74 00 6d 79 73 71 6c 5f 6e 61 74 69 76 65 5f
+ |70 61 73 73 77 6f 72 64 00
|""".stripMargin)
verifyEncode(expected, packet)
}