You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/24 22:02:05 UTC

[GitHub] BasPH commented on a change in pull request #4763: [AIRFLOW-3946] Deprecate utils.file.TemporaryDirectory

BasPH commented on a change in pull request #4763: [AIRFLOW-3946] Deprecate utils.file.TemporaryDirectory
URL: https://github.com/apache/airflow/pull/4763#discussion_r259643109
 
 

 ##########
 File path: airflow/utils/file.py
 ##########
 @@ -23,11 +23,15 @@
 import errno
 import os
 import shutil
+from contextlib import contextmanager
 
 Review comment:
   That's exactly what happened. The Python convention is to group by stdlib, 3rd party libs, application libs and sort alphabetically within those groups. Since `contextlib` is in the stdlib, it was moved to the 1st group, and placed after `import shutil` because alphabetical order.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services