You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 15:54:41 UTC
[GitHub] [airflow] takuti opened a new pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
takuti opened a new pull request #21158:
URL: https://github.com/apache/airflow/pull/21158
Noticed two errors in the [Lineage documentation page](https://airflow.apache.org/docs/apache-airflow/stable/lineage.html):
- Inline code highlight "task_id=\`\`run_me_first\`\`" doesn't work due to a missing whitespace.
- Sample name of custom lineage backend, `ExampleBackend` , is different from the one configured above - `CustomBackend`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1025068562
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1025087263
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] takuti commented on a change in pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
takuti commented on a change in pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#discussion_r795053690
##########
File path: docs/apache-airflow/lineage.rst
##########
@@ -71,7 +71,7 @@ for the downstream task.
.. note:: Operators can add inlets and outlets automatically if the operator supports it.
-In the example DAG task ``run_this`` (task_id=``run_me_first``) is a BashOperator that takes 3 inlets: ``CAT1``, ``CAT2``, ``CAT3``, that are
+In the example DAG task ``run_this`` (task_id = ``run_me_first``) is a BashOperator that takes 3 inlets: ``CAT1``, ``CAT2``, ``CAT3``, that are
Review comment:
Thank you for telling the original intention :) Adjusted accordingly. Please reconfirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21158:
URL: https://github.com/apache/airflow/pull/21158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1025048717
>will re-create a new PR once failed.
You won't need to create a new one. **If** you need to trigger the CI to start over, you can close this one and there will be a button to re-open it with everything still saved. It's just two clicks. But if the CI is still failing, that's obviously not going to help anything and just add more server load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1024479791
I know you didn't change this, but line 99 has a typo that you may as well fix while you are in there: `LinageBackend` should be `LineageBackend`.
You may need to close and re-open the PR to get that image to rebuild so the tests will pass, but other than that it LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] takuti commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
takuti commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1025053715
Actually all checks have passed now. I don't think I'm blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1023362232
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#discussion_r795006915
##########
File path: docs/apache-airflow/lineage.rst
##########
@@ -71,7 +71,7 @@ for the downstream task.
.. note:: Operators can add inlets and outlets automatically if the operator supports it.
-In the example DAG task ``run_this`` (task_id=``run_me_first``) is a BashOperator that takes 3 inlets: ``CAT1``, ``CAT2``, ``CAT3``, that are
+In the example DAG task ``run_this`` (task_id = ``run_me_first``) is a BashOperator that takes 3 inlets: ``CAT1``, ``CAT2``, ``CAT3``, that are
Review comment:
```suggestion
In the example DAG task ``run_this`` (``task_id=run_me_first``) is a BashOperator that takes 3 inlets: ``CAT1``, ``CAT2``, ``CAT3``, that are
```
Whitespace is not the problem, this is formatted incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] takuti commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst
Posted by GitBox <gi...@apache.org>.
takuti commented on pull request #21158:
URL: https://github.com/apache/airflow/pull/21158#issuecomment-1024833424
Thank you for reviewing. I fixed the typo. Let me first see how the latest CI goes, and will re-create a new PR once failed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org